[Quesiton] About the performance of utils.removeItems

[finscn]

I found utils.removeItems is this :

    removeItems: function (arr, startIdx, removeCount)
    {
        var length = arr.length;

        if (startIdx >= length || removeCount === 0)
        {
            return;
        }

        removeCount = (startIdx+removeCount > length ? length-startIdx : removeCount);
        for (var i = startIdx, len = length-removeCount; i < len; ++i)
        {
            arr[i] = arr[i + removeCount];
        }

        arr.length = len;
    },

Why don't use :

arr.splice(startIdx, removeCount);

I think arr.splice is more fast than current utils.removeItems

[finscn]

I've tested , use :

    removeItems: function (arr, startIdx, removeCount)
    {
         arr.splice(startIdx, removeCount);
    },

Everything is OK and with better performance .

[englercj]

Here is some reading:

#2205
#2209
https://gamealchemist.wordpress.com/2013/05/01/lets-get-those-javascript-arrays-to-work-fast/

splice is almost always slower than our removeItems function, but also splice generates a new array every time it runs which can create unnecessary GC burden.

[finscn]

Oh, I think maybe different js engine will present different result .
I will do more test again. Thanks .

By the way , the Article at 2013 is too old , maybe the conclusion is out.

[englercj]

Landscape changes for sure, but like I mentioned the big one for us is that splice creates a new array and we certainly dont want that garbage.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.