Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HitTest hole fix #6159

Merged
merged 4 commits into from Oct 22, 2019
Merged

HitTest hole fix #6159

merged 4 commits into from Oct 22, 2019

Conversation

ivanpopelyshev
Copy link
Collaborator

@ivanpopelyshev ivanpopelyshev commented Oct 12, 2019

@codecov-io
Copy link

codecov-io commented Oct 12, 2019

Codecov Report

Merging #6159 into dev will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #6159      +/-   ##
==========================================
+ Coverage   70.07%   70.09%   +0.01%     
==========================================
  Files         195      195              
  Lines        9957     9960       +3     
==========================================
+ Hits         6977     6981       +4     
+ Misses       2980     2979       -1
Impacted Files Coverage Δ
packages/graphics/src/GraphicsGeometry.js 75.78% <100%> (+0.19%) ⬆️
packages/graphics/src/Graphics.js 73.98% <0%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd2c935...6e22ae8. Read the comment docs.

Copy link
Member

@bigtimebuddy bigtimebuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verification looks good, great work 👍 The only thing might be to add a unit-test for this case. It's so easy to verify with a test because it's mostly math to check for the contains.

@ivanpopelyshev
Copy link
Collaborator Author

Added test.

@cursedcoder
Copy link
Member

What if we add a hole inside a hole?

@ivanpopelyshev
Copy link
Collaborator Author

Yes, its in the test.

@ivanpopelyshev
Copy link
Collaborator Author

@cursedcoder do you think there'll be people who call beginHole() inside a hole? :)

Copy link
Member

@GoodBoyDigital GoodBoyDigital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work man!

@bigtimebuddy bigtimebuddy merged commit 4e2e2f0 into dev Oct 22, 2019
@bigtimebuddy bigtimebuddy deleted the fix-hole-hittest branch October 22, 2019 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants