New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HitTest hole fix #6159
HitTest hole fix #6159
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #6159 +/- ##
==========================================
+ Coverage 70.07% 70.09% +0.01%
==========================================
Files 195 195
Lines 9957 9960 +3
==========================================
+ Hits 6977 6981 +4
+ Misses 2980 2979 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verification looks good, great work 👍 The only thing might be to add a unit-test for this case. It's so easy to verify with a test because it's mostly math to check for the contains.
Added test. |
What if we add a hole inside a hole? |
Yes, its in the test. |
@cursedcoder do you think there'll be people who call beginHole() inside a hole? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work man!
Fix for #6156 , thanks to @xuyangbill
Doesn't work: https://www.pixiplayground.com/#/edit/XSqLaGQ_Htc9T1N8WSYlj
Fixed: https://www.pixiplayground.com/#/edit/qZJGOVcZm~qTrm2orFgtX