Fix Texture.clone() #7365
Merged
Fix Texture.clone() #7365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigtimebuddy
approved these changes
Apr 2, 2021
ShukantPal
approved these changes
Apr 2, 2021
ShukantPal
added
the
✅ Ready To Merge
ivanpopelyshev
approved these changes
Apr 2, 2021
|
Thank you @dev7355608 🎉 |
bigtimebuddy
pushed a commit
that referenced
this pull request
Apr 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Texture.clone()doesn't create a perfect clone. Bothorigandframeare cloned and passed to the constructor; consequently,clone.noFrameis always false andclone.frame !== clone.orig.These changes ensure that
texture.noFrame === clone.noFrameand(texture.frame === texture.orig) === (clone.frame === clone.orig).Pre-Merge Checklist
npm run lint)npm run test)