Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: export shapeBuildCommandMap to allow custom shape primitives #10508

Merged
merged 9 commits into from
Jun 18, 2024
Merged

feat: export shapeBuildCommandMap to allow custom shape primitives #10508

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7fcb3a3
Export shapeBuildCommandMap to allow custom shape primitives
ShukantPal May 5, 2024
6a4a6bd
Rename to shapeBuilders
ShukantPal May 5, 2024
69dce19
Use extensions for shapeBuilders
ShukantPal May 13, 2024
f0816bb
Merge branch 'dev' into shukant/export-shape-build-map
Zyie Jun 17, 2024
3224d58
feat: Allow for RenderGroups to be enabled AND disabled (#10623)
GoodBoyDigital Jun 18, 2024
c30bf8c
feat: add container reparenting (#10585)
Zyie Jun 18, 2024
954b17d
feat: Add attribute.divisor field for instanced rendering (#10396)
codedpalette Jun 18, 2024
04fc604
Merge branch 'dev' into shukant/export-shape-build-map
Zyie Jun 18, 2024
ddfdaf0
update to use extensions
Zyie Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/scene/graphics/shared/utils/buildContextBatches.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import type { GpuGraphicsContext } from '../GraphicsContextSystem';
import type { GraphicsPath } from '../path/GraphicsPath';
import type { ShapePath } from '../path/ShapePath';

const buildMap: Record<string, ShapeBuildCommand> = {
export const shapeBuildCommandMap: Record<string, ShapeBuildCommand> = {
ShukantPal marked this conversation as resolved.
Show resolved Hide resolved
rectangle: buildRectangle,
polygon: buildPolygon,
triangle: buildTriangle,
Expand Down Expand Up @@ -86,7 +86,7 @@ function addTextureToGeometryData(

const points: number[] = [];

const build = buildMap.rectangle;
const build = shapeBuildCommandMap.rectangle;

const rect = tempRect;

Expand Down Expand Up @@ -158,7 +158,7 @@ function addShapePathToGeometryData(

const points: number[] = [];

const build = buildMap[shape.type];
const build = shapeBuildCommandMap[shape.type];

// TODO - this can be cached...
// TODO - THIS IS DONE TWICE!!!!!!
Expand Down Expand Up @@ -261,7 +261,7 @@ function getHoleArrays(shape: ShapePath)
// TODO - need to transform the points via there transform here..
const holePoints: number[] = [];

const holeBuilder = buildMap[holePrimitive.type] as ShapeBuildCommand;
const holeBuilder = shapeBuildCommandMap[holePrimitive.type] as ShapeBuildCommand;

holeBuilder.build(holePrimitive, holePoints);

Expand Down
Loading