Change BufferResource.data type to include all possible typed arrays
#9332
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c75dba7:
|
| * @param {PIXI.IBlobOptions} options | ||
| * @param {boolean}[options.autoLoad] - whether to fetch the data immediately; | ||
| * you can fetch it later via {@link PIXI.BlobResource#load} | ||
| * @param {boolean}[options.width] - the width in pixels. | ||
| * @param {boolean}[options.height] - the height in pixels. | ||
| */ | ||
| constructor(source: string | Uint8Array | Uint32Array | Float32Array, | ||
| options: IBlobOptions = { width: 1, height: 1, autoLoad: true }) | ||
| constructor(source: string | Int8Array | Uint8Array | Uint8ClampedArray | Int16Array | Uint16Array | Int32Array |
There was a problem hiding this comment.
should we consider making a type for :Int8Array | Uint8Array | Uint8ClampedArray | Int16Array | Uint16Array | Int32Array | Uint32Array | Float32Array
Might make all the functions params a little less wordy!
There was a problem hiding this comment.
Created the BufferType type. Not sure if it's the best name though. Maybe more specific like BufferResourceDataType is better?
|
I noticed that removing the documentation of |
bigtimebuddy
added
the
✅ Ready To Merge
Description of change
The spec allows
Uint8ClampedArray:Must have been this bug in Chrome, which has been fixed a long time ago: https://bugs.chromium.org/p/chromium/issues/detail?id=961658
Added all typed array types that are allowed in
texImage2Das listed here: https://registry.khronos.org/webgl/specs/latest/2.0/#3.7.6Extended the automatic type detection in
fromBuffer.Removed
format: FORMATS.RGBA,from the defaultfromBufferoptions, because that's the default generally.Pre-Merge Checklist
npm run lint)npm run test)