Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRESIDECMS-1213 : Fixed the side navBar text issue. #466

Merged
merged 1 commit into from Jun 15, 2018

Conversation

@cfmitrah
Copy link
Contributor

commented Apr 23, 2018

No description provided.

@DominicWatson

This comment has been minimized.

Copy link
Contributor

commented Apr 24, 2018

Hey @cfmitrah thanks for this :). What happens in the case of applying this change? Does the nav item then work on two lines? Are you able to upload a screen shot here?

Thanks again, really appreciated.

@cfmitrah

This comment has been minimized.

Copy link
Contributor Author

commented Apr 25, 2018

Hi @DominicWatson @sebduggan
BTW before our changes the nav bar looks like this when we've select French language
beforethechanges

After the changes applied the nav bar displays the text without breaking
afterthechanges

Thanks

@sebduggan

This comment has been minimized.

Copy link
Contributor

commented Apr 27, 2018

Thanks for this @cfmitrah - I took what you did and ran with it a bit so the text indentation lines up on subsequent lines...

@DominicWatson DominicWatson merged commit 0c2fdf2 into pixl8:stable Jun 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.