Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRESIDECMS-749 : Fixed the grid fields issue having extra spaces. #474

Merged
merged 3 commits into from Apr 27, 2018

Conversation

@cfmitrah
Copy link
Contributor

commented Apr 27, 2018

No description provided.

@sebduggan
Copy link
Contributor

left a comment

This is quite a verbose way of doing this. The same can be achieved simply with:

return listToArray( fields, ", " );

This sees both commas and spaces as separators...

@cfmitrah

This comment has been minimized.

Copy link
Contributor Author

commented Apr 27, 2018

@sebduggan I guess that the space will comes for each grid fields like ('birth year') So only i added like that, Hope the DB columns has not having spaces. Your guess is right. I change that.

Thank you

@sebduggan sebduggan merged commit c45cdd5 into pixl8:release-10.9.0 Apr 27, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sebduggan

This comment has been minimized.

Copy link
Contributor

commented Apr 27, 2018

Thanks @cfmitrah!

I think if we have spaces in our db column names, then we're going to have much bigger problems than this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.