Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature presidecms 805 #490

Closed

Conversation

@cfmitrah
Copy link
Contributor

commented May 9, 2018

No description provided.

@DominicWatson

This comment has been minimized.

Copy link
Contributor

commented May 9, 2018

I think this could be cool but have doubts about this in core / this implementation.

A couple of things:

  • favicons are a little more complex these days than just uploading a single icon against a site
  • should not be called main_image
  • should probably have a dedicated UI

It might be good to start this as a separate extension that adds some more powerful features around favicons (perhaps hooking into APIs that will generate all the various favicons for you based on an uploaded large icon). Other considerations include changing the physical filename of favicons when you make changes to the favicon (to help with browser favicon caching).

I'm closing this for now and will comment on the ticket. Really appreciate the contribution, just not sure this is ready yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.