Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRESIDECMS-1239 : Added image thumbnail in asset browser #492

Merged

Conversation

@cfmitrah
Copy link
Contributor

@cfmitrah cfmitrah commented May 12, 2018

I've added image thumbnail in asset browser while picking from CKEditor
asset_browser

Copy link
Contributor

@DominicWatson DominicWatson left a comment

Thanks for this @cfmitrah. Its not quite right unfortunately. Could you check the review?

Loading

@@ -1,6 +1,6 @@
<cfscript>
ext = ListLast( args.storage_path ?: "", "." );
iconUrl = event.buildLink( systemStaticAsset = "/images/asset-type-icons/16px/#LCase( ext )#.png" );
iconUrl = event.buildLink( assetId=args.id ?: "", derivative='pickerIcon' );
Copy link
Contributor

@DominicWatson DominicWatson May 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't quite right, unfortunately. This will break a lot of other places that can't render an image for assets such as PDFs, etc.

I think the change that needs to happen here is the code that renders the asset for the picker or, the code that you have here should be made in /renderers/image/icon.cfm (note the different folder).

Loading

@DominicWatson
Copy link
Contributor

@DominicWatson DominicWatson commented May 16, 2018

Awesome sauce guys, thank you!

Loading

@DominicWatson DominicWatson merged commit 202e0ef into pixl8:release-10.9.0 May 16, 2018
1 check passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants