Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature_PRESIDECMS-827 #516

Closed

Conversation

@cfmitrah
Copy link
Contributor

commented Jun 1, 2018

- Added Google Tag Manager (GTM) Integration
feature_PRESIDECMS-827
    - Added Google Tag Manager (GTM) Integration
@cfmitrah cfmitrah referenced this pull request Jun 1, 2018
@DominicWatson

This comment has been minimized.

Copy link
Contributor

commented Jun 7, 2018

Hey guys, thanks for this. I have a strong feeling that this should be an extension that follows the same pattern as: https://github.com/pixl8/preside-ext-google-analytics.

Apologies for not triaging the ticket sooner and making that clear. However, general rules:

  • If a JIRA ticket hasn't been marked as "Accepted", then its worth asking about it before going ahead
  • If the feature is about integrating with a proprietary third party (i.e. Google), then it should probably not belong in core
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.