Permalink
Browse files

5.8.7 is crashing with forks and evals.

Skip the tests and recommend 5.8.8 and above.
  • Loading branch information...
1 parent 9b3c3ac commit 8a94655ad7144442efff63ccafde2a26177bedaa @pjcj committed Apr 18, 2011
Showing with 28 additions and 10 deletions.
  1. +8 −8 lib/Devel/Cover.pm
  2. +1 −1 test_output/cover/fork.5.006001
  3. +6 −0 tests/eval_sub.t
  4. +6 −0 tests/eval_use.t
  5. +1 −1 tests/fork
  6. +6 −0 tests/md5.t
View
@@ -1306,14 +1306,14 @@ L<http://github.com/pjcj/Devel--Cover>.
=over
-=item * Perl 5.6.1 or greater. Perl 5.8.2 or greater is recommended.
-
-Perl 5.7.0 is unsupported. Perl 5.8.2 or greater is recommended.
-Whilst Perl 5.6 should mostly work you will probably miss out on
-coverage information which would be available using a more modern
-version and will likely run into bugs in perl. Perl 5.8.0 will give
-slightly different results to more recent versions due to changes in the
-op tree.
+=item * Perl 5.6.1 or greater. Perl 5.8.8 or greater is recommended.
+
+Perl 5.7.0 is unsupported. Perl 5.8.8 or greater is recommended. Perl
+5.8.7 has problems and may crash. Whilst Perl 5.6 should mostly work
+you will probably miss out on coverage information which would be
+available using a more modern version and will likely run into bugs in
+perl. Perl 5.8.0 will give slightly different results to more recent
+versions due to changes in the op tree.
=item * The ability to compile XS extensions.
@@ -33,7 +33,7 @@ line err stmt bran cond sub code
7 # The latest version of this software should be available from my homepage:
8 # http://www.pjcj.net
9
-10 # __COVER__ skip_test $^O eq "MSWin32"
+10 # __COVER__ skip_test $^O eq "MSWin32" || $] == 5.008007
11 # __COVER__ skip_reason Fork unreliable
12
13 2 $x = 1;
View
@@ -12,6 +12,12 @@ use warnings;
use Devel::Cover::Test 0.75;
+if ($] == 5.008007)
+{
+ eval "use Test::More skip_all => 'Crashes 5.8.7'";
+ exit;
+}
+
my $run_test = sub
{
my $test = shift;
View
@@ -12,6 +12,12 @@ use warnings;
use Devel::Cover::Test 0.75;
+if ($] == 5.008007)
+{
+ eval "use Test::More skip_all => 'Crashes 5.8.7'";
+ exit;
+}
+
my $run_test = sub
{
my $test = shift;
View
@@ -7,7 +7,7 @@
# The latest version of this software should be available from my homepage:
# http://www.pjcj.net
-# __COVER__ skip_test $^O eq "MSWin32"
+# __COVER__ skip_test $^O eq "MSWin32" || $] == 5.008007
# __COVER__ skip_reason Fork unreliable
$x = 1;
View
@@ -21,6 +21,12 @@ my $t = "md5";
my $ft = "$base/tests/$t";
my $fg = "$base/tests/trivial";
+if ($] == 5.008007)
+{
+ eval "use Test::More skip_all => 'Crashes 5.8.7'";
+ exit;
+}
+
my $run_test = sub
{
my $test = shift;

0 comments on commit 8a94655

Please sign in to comment.