New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t/e2e/abigint.t may fail #225

Open
eserte opened this Issue Nov 8, 2018 · 6 comments

Comments

Projects
None yet
3 participants
@eserte
Contributor

eserte commented Nov 8, 2018

On some perl systems I see the following failure:

#   Failed test 'output'
#   at blib/lib/Devel/Cover/Test.pm line 306.
# +----+-----------------------------------------------------------------------------------------------------------------------------------------+--------------------------------------------------------------------------------------------------------+
# | Elt|Got                                                                                                                                      |Expected                                                                                                |
# +----+-----------------------------------------------------------------------------------------------------------------------------------------+--------------------------------------------------------------------------------------------------------+
# *  99|  '16    ***     50      1      0   if bless( {"sign" => "+","value" => bless( [1], \'Math::BigInt::Calc\' )}, \'Math::BigInt\' ) >= $x  |  '16    ***     50      1      0   if bless( {"sign" => "+","value" => [1]}, \'Math::BigInt\' ) >= $x  *
# +----+-----------------------------------------------------------------------------------------------------------------------------------------+--------------------------------------------------------------------------------------------------------+
# Looks like you failed 1 test of 1.
t/e2e/abigint.t ............. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/1 subtests 
@manwar

This comment has been minimized.

manwar commented Nov 12, 2018

Where can I locate the test script t/e2e/abigint.t?

@eserte

This comment has been minimized.

Contributor

eserte commented Nov 12, 2018

Where can I locate the test script t/e2e/abigint.t?

Probably only available in a generated CPAN distribution, not in the github source...

@manwar

This comment has been minimized.

manwar commented Nov 13, 2018

This is what I get when I build the distribution:

     manwar@ubuntu:~/Devel--Cover/Devel-Cover-1.31$ tree t
     t
     ├── 00-report-prereqs.t
     ├── internal
     │   ├── criteria.t
     │   ├── inc_filter 
     │   │   ├── cwd
     │   │   │   └── lib
     │   │   └── cwd_lib
     │   ├── inc_filter.t
     │   ├── launch.t
     │   └── subprocess.t
     └── regexp
     └── regexp_eval.t
@Tux

This comment has been minimized.

Contributor

Tux commented Nov 13, 2018

Correct. Now continue ...

$ tree t
t
├── internal
│   ├── criteria.t
│   ├── inc_filter
│   │   ├── cwd
│   │   │   └── lib
│   │   └── cwd_lib
│   ├── inc_filter.t
│   ├── launch.t
│   └── subprocess.t
└── regexp
    └── regexp_eval.t

6 directories, 5 files
$ perl Mafile.PL
⋮
$ tree t
t
├── e2e
│   ├── aaccessor.t
│   ├── aalias1.t
│   ├── aalias.t
│   ├── aand.t
│   ├── abigint.t
⋮
│   ├── change.t
│   ├── eval_merge_sep.t
│   ├── eval_merge.t
│   ├── eval_sub.t
│   ├── eval_use.t
│   └── md5.t
├── internal
│   ├── criteria.t
│   ├── inc_filter
│   │   ├── cwd
│   │   │   └── lib
│   │   └── cwd_lib
│   ├── inc_filter.t
│   ├── launch.t
│   └── subprocess.t
└── regexp
    └── regexp_eval.t

7 directories, 78 files

the source for e2e/abigint.t is tests/bigint, which you could have found in Makefile.PL

@manwar

This comment has been minimized.

manwar commented Nov 13, 2018

Aaah..I used "dzil build" to build the distribution to see if I can generate the test script. Only Makefile.PL creates those test script, apparently.

@Tux

This comment has been minimized.

Contributor

Tux commented Nov 13, 2018

Use dzil for dzil projects. Devel::Cover is not a dzil project.
When all you have is a hammer …
Makefile.Pl calls utils/create_gold and/or utils/create_gold which in turn create t/e2e/*
If you insist on dzil, which this is not a suitable project for, you probably have to create your own config files for it to mimic Makefile.PL's behavior. Not worth the trouble IMHO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment