New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve uncoverable file #148

Merged
merged 2 commits into from Feb 4, 2016

Conversation

Projects
None yet
2 participants
@kaoru
Contributor

kaoru commented Jan 31, 2016

Hi Paul,

I got Devel::Cover as my CPAN Pull Request Challenge distribution for January 2016. I left it until the last weekend as usual, but hopefully these changes are useful :-)

I noticed that the POD for -uncoverable_file wasn't quite correct when compared with the actual code. It said .uncoverable was used by default and made no mention of ~/.uncoverable at all. It also made it sound like the parameter would override the default, which isn't right, the defaults are always used.

Part of the confusion there was that there were defaults in the cover binary, but they were redundant. That's what my second commit addresses.

Thanks!

kaoru added some commits Jan 31, 2016

Remove redundant uncoverable_file defaults
These defaults are always used as per
Devel::Cover::DB::uncoverable_files.

@pjcj pjcj merged commit 3592dea into pjcj:master Feb 4, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@pjcj

This comment has been minimized.

Show comment
Hide comment
@pjcj

pjcj Feb 4, 2016

Owner

Thanks so much! I have merged your branch and it will be in the next release. I had left the uncoverable code undocumented for a while as I wanted to try it out more and have the freedom to change it. But since I never really did that I decided I might as well document it a bit and let people use it. Thanks for improving it.

I have also added you to the Contributers file. If you don't want this, or you would like your entry changed, please just let me know, or send a pull request.

Thanks again.

Owner

pjcj commented Feb 4, 2016

Thanks so much! I have merged your branch and it will be in the next release. I had left the uncoverable code undocumented for a while as I wanted to try it out more and have the freedom to change it. But since I never really did that I decided I might as well document it a bit and let people use it. Thanks for improving it.

I have also added you to the Contributers file. If you don't want this, or you would like your entry changed, please just let me know, or send a pull request.

Thanks again.

@kaoru

This comment has been minimized.

Show comment
Hide comment
@kaoru

kaoru Feb 6, 2016

Contributor

That's great, thanks for the mention in the Contributors file :-) I got another one of your modules for my Pull Request Challenge for February (https://github.com/pjcj/Gedcom.pm) so you'll be hearing from me again in a couple of weeks I expect.

Contributor

kaoru commented Feb 6, 2016

That's great, thanks for the mention in the Contributors file :-) I got another one of your modules for my Pull Request Challenge for February (https://github.com/pjcj/Gedcom.pm) so you'll be hearing from me again in a couple of weeks I expect.

@kaoru kaoru deleted the kaoru:improve-uncoverable-file branch Feb 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment