New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile.PL cleanup #17

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@ambs
Contributor

ambs commented Jun 6, 2016

Hi,
This is a PR from PRChallenge (just for reference).

For now, some cleanup in Makefile.PL.
But I am also getting some test failures that I will try to debug. Any hint is welcome.

t/resolve_read_only.t .. 108/1508 
# Test 1120 got: "2     DATE Saturday, 2nd April 1921\n" (t/Basic.pm at line 32 fail #1120)
#      Expected: "2     DATE 02 Apr 1921\n"
#  t/Basic.pm line 32 is:     &Test::ok(@a)
# Test 1471 got: "2     DATE Monday, 6th June 2016\n" (t/Basic.pm at line 32 fail #1471)
#      Expected: "2     DATE AFT    1989\n"
t/resolve_read_only.t .. Failed 2/1508 subtests
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jun 6, 2016

Coverage Status

Coverage remained the same at 70.615% when pulling d456ce0 on ambs:prc into 623d85d on pjcj:master.

coveralls commented Jun 6, 2016

Coverage Status

Coverage remained the same at 70.615% when pulling d456ce0 on ambs:prc into 623d85d on pjcj:master.

pjcj added a commit that referenced this pull request Sep 9, 2016

@pjcj

This comment has been minimized.

Show comment
Hide comment
@pjcj

pjcj Sep 9, 2016

Owner

Thanks! I have merged this with c872346.

I think the date problem is something to do with Date::Manip. I will look into that separately.

Sorry it took so long to get to, but thanks very much for looking through the code and putting this together.

Owner

pjcj commented Sep 9, 2016

Thanks! I have merged this with c872346.

I think the date problem is something to do with Date::Manip. I will look into that separately.

Sorry it took so long to get to, but thanks very much for looking through the code and putting this together.

@pjcj pjcj closed this Sep 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment