New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing the failing tests #7

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@tudorconstantin
Contributor

tudorconstantin commented May 3, 2015

The tests are failing when Date::Manip is installed.
The reason is that there are dates in the Gedcom file which look like this

AFT 1989

AFT comes from after
ParseDate() returns the current day when it parses those dates so that the roundtrip orig_date->parsed_date->orig_date ends with a different orig_date and the tests are failing.

The fix consists skipping from parsing those dates

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls May 3, 2015

Coverage Status

Coverage decreased (-0.19%) to 70.42% when pulling 63bd2cd on tudorconstantin:master into 26cd85f on pjcj:master.

coveralls commented May 3, 2015

Coverage Status

Coverage decreased (-0.19%) to 70.42% when pulling 63bd2cd on tudorconstantin:master into 26cd85f on pjcj:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls May 3, 2015

Coverage Status

Coverage decreased (-0.19%) to 70.42% when pulling 63bd2cd on tudorconstantin:master into 26cd85f on pjcj:master.

coveralls commented May 3, 2015

Coverage Status

Coverage decreased (-0.19%) to 70.42% when pulling 63bd2cd on tudorconstantin:master into 26cd85f on pjcj:master.

@pjcj

This comment has been minimized.

Show comment
Hide comment
@pjcj

pjcj Sep 9, 2016

Owner

Thank you very much for this! I have merged it as 42eee59, with minor formatting changes to the comments.

I'm so sorry it took me so long to get to actually merging it.

Owner

pjcj commented Sep 9, 2016

Thank you very much for this! I have merged it as 42eee59, with minor formatting changes to the comments.

I'm so sorry it took me so long to get to actually merging it.

@pjcj pjcj closed this Sep 9, 2016

@tudorconstantin

This comment has been minimized.

Show comment
Hide comment
@tudorconstantin

tudorconstantin Sep 9, 2016

Contributor

Haha, no problem I'm glad you found some of it useful

On Fri, Sep 9, 2016, 23:45 Paul Johnson notifications@github.com wrote:

Thank you very much for this! I have merged it as 42eee59
42eee59,
with minor formatting changes to the comments.

I'm so sorry it took me so long to get to actually merging it.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#7 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABOmEMGS_L3Hh5e9xxTKyKFyiEo8Lswwks5qocWEgaJpZM4EOiy4
.

Contributor

tudorconstantin commented Sep 9, 2016

Haha, no problem I'm glad you found some of it useful

On Fri, Sep 9, 2016, 23:45 Paul Johnson notifications@github.com wrote:

Thank you very much for this! I have merged it as 42eee59
42eee59,
with minor formatting changes to the comments.

I'm so sorry it took me so long to get to actually merging it.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#7 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABOmEMGS_L3Hh5e9xxTKyKFyiEo8Lswwks5qocWEgaJpZM4EOiy4
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment