Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix scoping issues with "no autodie" #41

Merged
merged 6 commits into from Mar 14, 2014

Conversation

Projects
None yet
2 participants
Collaborator

nthykier commented Oct 16, 2013

No description provided.

nthykier added some commits Oct 16, 2013

@nthykier nthykier Move scope guard package into its own module
Signed-off-by: Niels Thykier <niels@thykier.net>
605df4a
@nthykier nthykier Add module to abstract away "on end of scope" calls
Signed-off-by: Niels Thykier <niels@thykier.net>
abdd7f1
@nthykier nthykier Implement a proper "scoped-hook-stack"
Signed-off-by: Niels Thykier <niels@thykier.net>
fc39bba
@nthykier nthykier Properly re-install subs removed by "no autodie;"
Signed-off-by: Niels Thykier <niels@thykier.net>
a98136a
@nthykier nthykier Add POD documentation to new modules
Signed-off-by: Niels Thykier <niels@thykier.net>
ac2c3aa
@nthykier nthykier autodie::S::GuardStack: Fix typo of _pop_hook
Signed-off-by: Niels Thykier <niels@thykier.net>
d711744
Collaborator

nthykier commented Mar 13, 2014

Hey @pjf, had a chance to review this branch? :)

Owner

pjf commented Mar 13, 2014

I have now! Running to brunch, then running the test in this pull request, then merging this pull request, then releasing a new autodie.

I appreciate the nudges so much.

<3 pjf

@pjf pjf added a commit that referenced this pull request Mar 14, 2014

@pjf pjf Merge remote-tracking branch 'nthykier/rt-72053' into testing_41
Test merge of GH #41

* nthykier/rt-72053:
  autodie::S::GuardStack: Fix typo of _pop_hook
  Add POD documentation to new modules
  Properly re-install subs removed by "no autodie;"
  Implement a proper "scoped-hook-stack"
  Add module to abstract away "on end of scope" calls
  Move scope guard package into its own module
87289ba
Owner

pjf commented Mar 14, 2014

Hmm, Travis loves this ( https://travis-ci.org/pjf/autodie/builds/20737917 ), but I seem to be getting a test failure locally. Investigating...

Owner

pjf commented Mar 14, 2014

And my local test fails were because I had a silly .gitignored travis directory floating around from testing a while back. Merging.

@pjf pjf added a commit that referenced this pull request Mar 14, 2014

@pjf pjf Merge remote-tracking branch 'nthykier/rt-72053'
GH #41

* nthykier/rt-72053:
  autodie::S::GuardStack: Fix typo of _pop_hook
  Add POD documentation to new modules
  Properly re-install subs removed by "no autodie;"
  Implement a proper "scoped-hook-stack"
  Add module to abstract away "on end of scope" calls
  Move scope guard package into its own module
a37affb

@pjf pjf merged commit d711744 into pjf:master Mar 14, 2014

1 check passed

default The Travis CI build passed
Details
Collaborator

nthykier commented Mar 14, 2014

On 2014-03-14 04:14, Paul Fenwick wrote:

Merged #41.


Reply to this email directly or view it on GitHub:
#41

Thanks :)

@pjf pjf added a commit that referenced this pull request Mar 30, 2014

@pjf pjf v2.24
        * FEATURE: Provide a stack backtrace when `Carp::Always` is enabled.
                   Note that sometimes this is not as pretty as it could
                   be, patches welcome.
                   (Thanks to Niels Thykier, GH #35)

        * BUGFIX: Fix situations where `no autodie` doesn't respect lexical
                  scope. (Thanks to Niels Thykier, GH #41, RT #72053,
                  RT #86396)

        * INTERNAL: Remove now unused variables in code (Niels Thykier).

        * DOCS: Make it extra-clear autodie doesn't check `print`.
                (Dave Rolsky, GH #39)

        * TEST: Removed obsolete boilerplate.t

        * TEST / INTERNAL: Enabled travis-ci for Perl 5.8

        * TEST: Stopped some Pod::Coverage tests failing under Perl 5.8

        * BUILD: Better support for building in a read-only directory
                 (courtesy Andrew Fresh, GH #46)
33aa3fb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment