New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Never throw an exception on kill 0, $pid if called in non-void context #72

Merged
merged 2 commits into from Mar 3, 2016

Conversation

Projects
None yet
2 participants
@mvgrimes
Contributor

mvgrimes commented Feb 1, 2016

If the called in list or scalar context, will no longer throw an
exception when kill(0,$pid) returns a zero value (or a value less the
number of pids supplied). Always dies if kill(0,$pid) is called in void
context.

Addresses issue #47. Submitted as part of the Feb 2016 PRC.

Never throw an exception on kill 0, $pid if called in non-void context
If the called in list or scalar context, will no longer throw an
exception when kill(0,$pid) returns a zero value (or a value less the
number of pids supplied). Always dies if kill(0,$pid) is called in void
context.
@nthykier

This comment has been minimized.

Show comment
Hide comment
@nthykier

nthykier Feb 29, 2016

Collaborator

Hi,

Sorry for the tardiness on our part.

Before merging this, is "1" really a portable signal number and are we sure that it is "HUP" on all platforms? Can't we use kill('HUP', <PID>) instead?

Collaborator

nthykier commented Feb 29, 2016

Hi,

Sorry for the tardiness on our part.

Before merging this, is "1" really a portable signal number and are we sure that it is "HUP" on all platforms? Can't we use kill('HUP', <PID>) instead?

@mvgrimes

This comment has been minimized.

Show comment
Hide comment
@mvgrimes

mvgrimes Mar 1, 2016

Contributor

Using 'HUP' does seem more portable. It also highlights a bug in my patch,
where we assume $signal is a number. I'm updating the PR with code to
address this. Thanks!

On Mon, Feb 29, 2016 at 2:30 PM, Niels Thykier notifications@github.com
wrote:

Hi,

Sorry for the tardiness on our part.

Before merging this, is "1" really a portable signal number and are we
sure that it is "HUP" on all platforms? Can't we use kill('HUP', )
instead?


Reply to this email directly or view it on GitHub
#72 (comment).

Contributor

mvgrimes commented Mar 1, 2016

Using 'HUP' does seem more portable. It also highlights a bug in my patch,
where we assume $signal is a number. I'm updating the PR with code to
address this. Thanks!

On Mon, Feb 29, 2016 at 2:30 PM, Niels Thykier notifications@github.com
wrote:

Hi,

Sorry for the tardiness on our part.

Before merging this, is "1" really a portable signal number and are we
sure that it is "HUP" on all platforms? Can't we use kill('HUP', )
instead?


Reply to this email directly or view it on GitHub
#72 (comment).

nthykier added a commit that referenced this pull request Mar 3, 2016

Merge pull request #72 from mvgrimes/kill-0
Never throw an exception on kill 0, $pid if called in non-void context

@nthykier nthykier merged commit 2d20c8d into pjf:master Mar 3, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment