Use ternary expressions with wantarray #26
Conversation
so finalize code doesn't need to be duplicated. (pull request challenge 2018)
# NB: We don't check the return status on close(), since | ||
# on failure it sets $?, which we then inspect for more | ||
# useful information. | ||
|
jkeenan
Jan 25, 2020
Collaborator
I oppose the deletion of the author's inline comment. I am now co-maintainer of this distribution and I found this comment helpful.
I oppose the deletion of the author's inline comment. I am now co-maintainer of this distribution and I found this comment helpful.
Primary motivation behind this PR is to get rid of duplication of
Such construct is prone to introduce bugs when something is introduced only in one branch, so although it doesn't introduce new functionality, it just makes it little bit less likely to introduce a buggy feature. |
Sorry, I'm not persuaded that the benefit outweighs the risk. Thank you very much. |
so finalize code doesn't need to be duplicated.
(pull request challenge 2018)