Use ternary expressions with wantarray

[happy-barney]

so finalize code doesn't need to be duplicated.

(pull request challenge 2018)

[jkeenan]

I oppose the deletion of the author's inline comment. I am now co-maintainer of this distribution and I found this comment helpful.

[jkeenan]

"If it ain't broke, don't fix it." Although the changes requested make the code more compact, it's not necessarily more readable and I doubt it improves functionality. Unless @pjf expresses a desire to apply this p.r. in the next 30 days, I will reject it.

[happy-barney]

Primary motivation behind this PR is to get rid of duplication of _process_child_error calls in form:

if (condition) {
   ... do something
   _process_child_error();
   return ...
} else {
   ... do something else
   _process_child_error();
   return ...
}

Such construct is prone to introduce bugs when something is introduced only in one branch, so although it doesn't introduce new functionality, it just makes it little bit less likely to introduce a buggy feature.

[jkeenan]

Primary motivation behind this PR is to get rid of duplication of _process_child_error calls in form:

if (condition) {
   ... do something
   _process_child_error();
   return ...
} else {
   ... do something else
   _process_child_error();
   return ...
}

Such construct is prone to introduce bugs when something is introduced only in one branch, so although it doesn't introduce new functionality, it just makes it little bit less likely to introduce a buggy feature.

Sorry, I'm not persuaded that the benefit outweighs the risk.

Thank you very much.
Jim Keenan