New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TinyDNS - Read path files from init.d script #6

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@fmbiete
Contributor

fmbiete commented Dec 3, 2013

I needed some solution for #2 and did some quick changes for it.

We already have the files defined in the init.d script, with a few args in the tinydns server it wil accept:

  • configfile and therefore root dir
  • logfile
  • pidfile
  • main server port

it would be very easy to implement the same changes in the others servers.

Regards,

@pjps

This comment has been minimized.

Owner

pjps commented Dec 3, 2013

Thank you so much for the patch; I'll merge it soon.

Thank you.

@pjps

This comment has been minimized.

Owner

pjps commented Dec 16, 2013

Hello Francisco,

Just to let you know, I'm yet to work on merging this patch. I was mostly occupied with other changes. A new release 1.05.9 is almost ready. I plan to defer merging of this patch and similar changes to other servers for the release after this one, ie. 1.06.0. Hope that's okay.

Thank you.

@fmbiete

This comment has been minimized.

Contributor

fmbiete commented Dec 17, 2013

No problem, I will be using git version with my patches until then, I only have to remeber to replace the binaries after each update.

Regards,

@msackman

This comment has been minimized.

msackman commented Mar 30, 2014

FWIW I'm interested in these changes being applied to all the daemons. None of these daemons should hard code at compile time where their config files should be read from, IMO.

@pjps

This comment has been minimized.

Owner

pjps commented Apr 2, 2014

Hello Matthew,

Yes, I'm working on adding same command-line options to all daemons.

@pjps

This comment has been minimized.

Owner

pjps commented Apr 5, 2014

Hello Francisco, Matthew,

I have finally merged this patch with some alteration and have added consistent command line options to other servers.

@fmbiete: May I have your email-id for the --author=<author> option to commit the changes?

Thank you.

@fmbiete

This comment has been minimized.

Contributor

fmbiete commented Apr 6, 2014

fbiete at gmail dot com

I'm waiting for these changes to hit EPEL soon 👍

@pjps

This comment has been minimized.

Owner

pjps commented Apr 6, 2014

Please see -> edb4769

Thank you.

@pjps pjps closed this Apr 6, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment