Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement - C++ Port of Darknet, Enabling OpenCV3 on Linux #21

Closed
wants to merge 10 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@prabindh
Copy link

prabindh commented Oct 20, 2016

Moving to C++ exposed a tiny error of using float* instead of float, as the storage is intended for an array that stores floats.

@prabindh

This comment has been minimized.

Copy link
Author

prabindh commented Oct 23, 2016

Merged latest commit from pjreddie (d8adaf8) (tree stuff). Now make will build both original darknet and darknet-cpp from same merged code-base (no separate .cpp files), thus making it easy to maintain. Please consider merge. Also fixed some real bugs (memory allocation, header includes, and CUBLAS error checks vs CUDA error checks).

@prabindh prabindh changed the title Bug fix - Usage of wrong datatype for allocation causing leak Enhancement - C++ Port of Darknet, Enabling OpenCV3 on Linux Oct 23, 2016

@prabindh

This comment has been minimized.

Copy link
Author

prabindh commented Oct 23, 2016

@prabindh

This comment has been minimized.

Copy link
Author

prabindh commented Nov 6, 2016

Since the original PR, there have been significant changes that are not merged, hence closing this and creating a new simpler PR (#24).

@prabindh prabindh closed this Nov 6, 2016

@Grabber

This comment has been minimized.

Copy link

Grabber commented on d41037a Nov 28, 2016

Are you sure about coco.c, detector.c and yolo.c float * to float changes? Code is initializing a **float not a *float.

This comment has been minimized.

Copy link
Owner Author

prabindh replied Jan 8, 2017

Lets look at the change in yolo.c, line 302. The probs[] array is passed to the function "get_detection_boxes". Looking at "get_detection_boxes()" implementation in src/detection_layer.c, a FLOAT value is assigned to each element of probs[] array, like below.

probs[index][0] = scale;

Hence each probs[] entry is a pointer to FLOAT, and this allocation does that.

Please let me know if this is not how you see it.

This comment has been minimized.

Copy link
Owner Author

prabindh replied Jan 8, 2017

And, sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.