From d06375766f5d9f64611749eb81e4b04c6a311548 Mon Sep 17 00:00:00 2001 From: Sauw Ming Date: Thu, 28 Sep 2017 03:44:53 +0000 Subject: [PATCH] Fixed #2046: ICE: Use STUN FINGERPRINT attribute when sending keepalives git-svn-id: https://svn.pjsip.org/repos/pjproject/trunk@5665 74dad513-b988-da41-8d7b-12977e46ad98 --- pjnath/src/pjnath/ice_session.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/pjnath/src/pjnath/ice_session.c b/pjnath/src/pjnath/ice_session.c index 27a29505c1..63a0d1c9c1 100644 --- a/pjnath/src/pjnath/ice_session.c +++ b/pjnath/src/pjnath/ice_session.c @@ -1217,10 +1217,12 @@ static void ice_keep_alive(pj_ice_sess *ice, pj_bool_t send_now) msg_data = PJ_POOL_ZALLOC_T(tdata->pool, pj_ice_msg_data); msg_data->transport_id = the_check->lcand->transport_id; - /* Temporarily disable FINGERPRINT. The Binding Indication - * SHOULD NOT contain any attributes. + /* RFC 5245 Section 10: + * The Binding Indication SHOULD contain the FINGERPRINT attribute + * to aid in demultiplexing, but SHOULD NOT contain any other + * attributes. */ - saved = pj_stun_session_use_fingerprint(comp->stun_sess, PJ_FALSE); + saved = pj_stun_session_use_fingerprint(comp->stun_sess, PJ_TRUE); /* Send to session */ addr_len = pj_sockaddr_get_len(&the_check->rcand->addr);