Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: 2to3 #348

Merged
merged 13 commits into from Mar 15, 2019

Conversation

Projects
None yet
2 participants
@docapotamus
Copy link
Member

docapotamus commented Mar 11, 2019

Against what I said in #346 it turned out to be easyish to port to Python 3.

docapotamus added some commits Mar 10, 2019

Fixed user tests, also...
- next now uses full_path rather than re-creating it
- pagination links corrected for new generators

@docapotamus docapotamus self-assigned this Mar 11, 2019

@docapotamus docapotamus requested a review from mcrmonkey Mar 11, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 11, 2019

Codecov Report

Merging #348 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #348   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          32     32           
  Lines        1913   1914    +1     
  Branches      304    308    +4     
=====================================
+ Hits         1913   1914    +1
Impacted Files Coverage Δ
pjuu/users/views.py 100% <ø> (ø) ⬆️
pjuu/lib/uploads.py 100% <ø> (ø) ⬆️
pjuu/configurator.py 100% <ø> (ø) ⬆️
pjuu/lib/alerts.py 100% <100%> (ø) ⬆️
pjuu/posts/views.py 100% <100%> (ø) ⬆️
pjuu/lib/__init__.py 100% <100%> (ø) ⬆️
pjuu/settings.py 100% <100%> (ø) ⬆️
pjuu/lib/tokens.py 100% <100%> (ø) ⬆️
pjuu/auth/backend.py 100% <100%> (ø) ⬆️
pjuu/__init__.py 100% <100%> (ø) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba580e4...936d365. Read the comment docs.

docapotamus added some commits Mar 11, 2019

Fixed coverage missing in pagination, also...
- Removed Vagrant file as I never use it
- Updated README for Python3 on Debian stretch

@docapotamus docapotamus changed the title 2to3 WIP: 2to3 Mar 11, 2019

@docapotamus docapotamus merged commit 44cbea3 into master Mar 15, 2019

4 checks passed

codecov/patch 100% of diff hit (target 100%)
Details
codecov/project 100% (+0%) compared to ba580e4
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.