Proposal: errors.First(e ...error) error

[2buisson]

First returns the first non-nil error, otherwise nil. Usefull when a function have to manage multiple independant errors.

reply, criticalErr := request() // very important
logErr := logReply(reply) // not important
writeErr := writeReply(reply) // not that important
return errors.First(criticalErr, writeErr, logErr)

I am willing to submit a PR.

[dcheney-atlassian]

Thanks but no thanks. This would encourage incorrect error handling, specifically

reply, criticalErr := request() // very important
logErr := logReply(reply) // not important  <== if criticalErr != nil, then the value of reply is undefined and must not be used.

[puellanivis]

There are cases where this is important, because you still need to Close something. But the code for doing this, is super simple in the first place, and far more clear than a “magic” return first non-nil error of a variadic list…

n, err := w.Write(b)
if err1 := w.Close(); err != nil {
  err = err1
}
return n, err

[davecheney]

Proposal declined.