From afd647d6a2682493cbf24bca20b542c21bff6f6f Mon Sep 17 00:00:00 2001 From: Jacob Heider Date: Tue, 14 Jan 2025 17:24:49 -0500 Subject: [PATCH 1/2] fix .nvmrc versions closes #10 --- fixtures/.nvmrc | 1 + src/sniff.test.ts | 1 + src/sniff.ts | 3 ++- 3 files changed, 4 insertions(+), 1 deletion(-) create mode 100644 fixtures/.nvmrc diff --git a/fixtures/.nvmrc b/fixtures/.nvmrc new file mode 100644 index 0000000..77181c9 --- /dev/null +++ b/fixtures/.nvmrc @@ -0,0 +1 @@ +^20 diff --git a/src/sniff.test.ts b/src/sniff.test.ts index 117945f..ff85ff5 100644 --- a/src/sniff.test.ts +++ b/src/sniff.test.ts @@ -92,6 +92,7 @@ Deno.test("devenv.ts", async (runner) => { "pnpm.io@7.33.7", ], [".node-version", "nodejs.org@16.16.0"], + [".nvmrc", "nodejs.org^20"], ["python-version/std/.python-version", "python.org~3.10"], ["python-version/commented/.python-version", "python.org~3.11"], [".ruby-version", "ruby-lang.org@3.2.1"], diff --git a/src/sniff.ts b/src/sniff.ts index 7b0a1a7..fba124e 100644 --- a/src/sniff.ts +++ b/src/sniff.ts @@ -162,7 +162,8 @@ export default async function (dir: Path) { async function version_file(path: Path, project: string) { let s = (await path.read()).trim(); if (s.startsWith("v")) s = s.slice(1); // v prefix has no effect but is allowed - s = `${project}@${s}`; + if (s.match(/^[0-9]/)) s = `@${s}`; // bare versions are `@`ed + s = `${project}${s}`; pkgs.push(utils.pkg.parse(s)); } From 9ff31da63705fd7644e2a7850c4adcd64dbe0e5d Mon Sep 17 00:00:00 2001 From: Jacob Heider Date: Tue, 14 Jan 2025 17:28:24 -0500 Subject: [PATCH 2/2] fix lints --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 02bd43d..9839494 100644 --- a/README.md +++ b/README.md @@ -142,7 +142,7 @@ environment. We recommend Visual Studio Code, `dev && code .` works great. > [!WARNING] > -> Unfortunately, this usually means you *must* open your editor via your +> Unfortunately, this usually means you _must_ open your editor via your > terminal. ## GitHub Actions