Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
Permit correct storage of section ID on initial insert
- Loading branch information
Showing
1 changed file
with
8 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
979337f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NateWr, I was ambivalent about doing this through function extension vs. through hooks -- maybe you have a preference?
979337f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@asmecher I'm not sure this is doing anything. The
sectionId
is now attached to the publication, not the submission, so nosectionId
should be saved to theSubmission
object. I think it will be ignored regardless.Maybe I'm misunderstanding something though...
979337f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I needed this in practice to get the QuickSubmit plugin working again after the versioning merges -- I didn't look deeply into the role of the
section_id
in thesubmissions
table, but there's still something there using it. @defstat and @NateWr, should this column be removed in favour of thepublications
table? If so, I suspect there are some remaining dependencies.979337f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure you had run the upgrade process? There should be no
section_id
in thesubmissions
table in themaster
branch...979337f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, clearly needs more investigation. I'll take another look and make sure I'm fully rebased.
979337f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, this now appears to be dead code. Maybe I was on an older rebase? I've reverted it.