New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#5183 Add locale strings for legends in forms #2803
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I left a few comments. In addition, let's move the new locale keys into pkp-lib. They can go into common.po
.
With that change, you shouldn't need any PRs for OMP or OPS. But go ahead and test the pkp-lib changes in OMP and OPS just to make sure.
cc: @NateWr |
Made changes, @NateWr. |
|
From this issue: pkp/pkp-lib#5183