Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5183 Add locale strings for legends in forms #2803

Merged
merged 7 commits into from Sep 30, 2020
Merged

#5183 Add locale strings for legends in forms #2803

merged 7 commits into from Sep 30, 2020

Conversation

thinkbulecount2
Copy link
Contributor

From this issue: pkp/pkp-lib#5183

Copy link
Member

@NateWr NateWr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I left a few comments. In addition, let's move the new locale keys into pkp-lib. They can go into common.po.

With that change, you shouldn't need any PRs for OMP or OPS. But go ahead and test the pkp-lib changes in OMP and OPS just to make sure.

locale/en_US/locale.po Outdated Show resolved Hide resolved
@thinkbulecount2
Copy link
Contributor Author

cc: @NateWr

@thinkbulecount2
Copy link
Contributor Author

Made changes, @NateWr.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ thinkbulecount2
❌ NateWr
You have signed the CLA already but the status is still pending? Let us recheck it.

@NateWr NateWr merged commit ddd664f into pkp:master Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants