New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*6625* refactor 'exclude and clear for single objects and exclude all issue object...' #425

Merged
merged 4 commits into from Feb 27, 2015

Conversation

Projects
None yet
2 participants
@jnugent
Copy link
Member

jnugent commented Feb 13, 2015

This is a rebase of the original pull request for bug 6625, rebased against ojs-dev-2_4.
Original pull request: #217

@@ -818,6 +818,25 @@ function deleteAllPubIds($journalId, $pubIdType) {
}
/**
* Delete the public ID of an issues.

This comment has been minimized.

@asmecher

asmecher Feb 17, 2015

Member

an issue

(int)$galleyId
)
);
$this->flushCache();

This comment has been minimized.

@asmecher

asmecher Feb 17, 2015

Member

I don't think flushCache does what you expect in ArticleGalleyDAO (see also another use just above this one).

This comment has been minimized.

@asmecher

asmecher Feb 25, 2015

Member

Did you address this, Jason?

This comment has been minimized.

@jnugent

jnugent Feb 26, 2015

Member

If you were referring to the fact that ArticleGalleyDAO had no specific implementation of flushCache and relied on what was in DAO, I've added a method override in ArticleGalleyDAO that specifically fetches the ArticleGalley cache and calls $cache->flush() now. It's part of the new commit from yesterday.

This comment has been minimized.

@asmecher

asmecher Feb 26, 2015

Member

Thanks, but how about the same for SuppFileDAO?

This comment has been minimized.

@jnugent

jnugent Feb 26, 2015

Member

whoops, done!

(int)$suppFileId
)
);
$this->flushCache();

This comment has been minimized.

@asmecher

This comment has been minimized.

Copy link
Member

asmecher commented Feb 17, 2015

This looks fine to me, with a couple of small comments, but I haven't tested it. @bozana, would you be able to run a test of this in the next little while? We're already into translations for OJS 2.4.6, so it's somewhat time-sensitive. Thanks!

foreach ($pubIdPlugins as $pubIdPlugin) {
$excludeSubmittName = 'excludeIssueObjects_' . $pubIdPlugin->getPubIdType();
$clearSubmittName = 'clearIssueObjects_' . $pubIdPlugin->getPubIdType();
$exlude = $clear = false;

This comment has been minimized.

@asmecher

asmecher Feb 26, 2015

Member

*exclude

@asmecher

This comment has been minimized.

Copy link
Member

asmecher commented Feb 26, 2015

Thanks, Jason, looks good. Just the one typo correction. I'd like to get this into the translation install ASAP, but would still like to go over it with UI/UX, so go ahead and merge, then we'll get it into the translation install, then review it with UI/UX. Kind of backwards, but I think it'll be fine.

jnugent added a commit that referenced this pull request Feb 27, 2015

Merge pull request #425 from jnugent/6625-fix
*6625* refactor 'exclude and clear for single objects and exclude all issue object...'

@jnugent jnugent merged commit fafbbe0 into pkp:ojs-dev-2_4 Feb 27, 2015

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@jnugent jnugent deleted the jnugent:6625-fix branch Feb 27, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment