[OPS] Email tag {$authorOrcidUrl} returns invalid URL when used as a link

[alexxxmendonca]

Describe the bug
The tag {$authorOrcidUrl} generated a dynamic link that enables authors to connect their ORCID iD via the API. In order to make a more user-friendly link, instead of using the tag itself, the template suggests to add it to a link (ie: within an a href).

However, the platform is automatically adding a ../management/settings/ before the {$authorOrcidUrl} tag, which invalidates the URL.

To Reproduce
Steps to reproduce the behavior:

1. Check your ORCID email templates
2. Check the link to connect ORCID ID (usually the one followed by the ORCID icon)
3. See how it points to ../management/settings/{$authorOrcidUrl}, which is not a valid URL

What application are you using?
Open Preprint Systems 3.2.0.1

Additional information

[ajnyga]

@withanage do you want to look at this?

[withanage]

@ajnyga
Haven't tested the ops with orcid, therefore will take some time. If it is ok, just assign me.

[librariam]

+1 from PKP|PS, same issue is reported by a journal on OJS 3.2.0.2 with ORCID plugin v1.1.2.3

Also related reports in this Forum thread

Editing to add that this is a new behaviour in OJS/OPS 3.2. In the same template in 3.1.2 nothing gets added in the URL before {$authorOrcidUrl} and it's therefore valid.

[withanage]

Hi @librariam @alexxxmendonca ,

I have tested the OPS for this problem yesterday.

I have looked into the problem, as you have described and it i a general problem in the template mechanism that always the current url gets added tp any tiny mce links (both in OPS and OJS 3.2 +)

Problem is not only orcid specific , other emails we did not have the links, therefore it was not visible.

I will talk with Nate about this and come back to you soon.

[withanage]

@alexxxmendonca @librariam

As assumed this was a general problem for URL editions in -The wysiwig editor. I have added a patch for that and update you as soon it is in the main OJS/OMP code.

[NateWr]

This was fixed as part of pkp/pkp-lib#6344. The fix will go out with 3.3 and 3.2.1-3.