Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fatal error when used on site registration #164

Open
ctgraham opened this issue Feb 10, 2021 · 5 comments
Open

Fatal error when used on site registration #164

ctgraham opened this issue Feb 10, 2021 · 5 comments
Assignees
Labels
bug

Comments

@ctgraham
Copy link

@ctgraham ctgraham commented Feb 10, 2021

Describe the bug
Plugin causes 500 error on the registration page in the site context.

To Reproduce
Steps to reproduce the behavior:

  1. Enable orcidProfile pluigin
  2. Initiate registration within the site context
  3. See error: PHP Fatal error: Uncaught Error: Call to a member function getId() on null

Expected behavior
Either registration using the orcidProfile plugin works within the site index, or the code fails gracefully to register without orcidProfile functionality in the site index.

Additional context
https://forum.pkp.sfu.ca/t/error-500-registration-page/57411/4?u=ctgraham

@asmecher
Copy link
Member

@asmecher asmecher commented Feb 18, 2021

@ctgraham, at a glance, it shouldn't be possible to enable the ORCID plugin site-wide. Do you know how you did that?

@ctgraham
Copy link
Author

@ctgraham ctgraham commented Feb 18, 2021

I think I just depended on the report from the forum rather than reproducing it locally.

@withanage
Copy link
Member

@withanage withanage commented Feb 19, 2021

@asmecher , it is actually possiblie to enable is sitewide using the config.inc.php

@ctgraham

Expected behavior
Either registration using the orcidProfile plugin works within the site index, or the code fails gracefully to register without > orcidProfile functionality in the site index.

I would prefer for disabing the functionality for the site-index , cause the users generally do not need the orcid functionality fwithout a journal.

@withanage
Copy link
Member

@withanage withanage commented Feb 28, 2021

I have released the following plugin versions addressing this.

OJS 3.1 https://github.com/pkp/orcidProfile/releases/tag/v1_1_1-12
OJS 3.2 https://github.com/pkp/orcidProfile/releases/tag/v1_1_2-7

I will ask the forum users to do functional tests.

OJS 3.3 will follow soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants