required tagit metadata fields not validated

[bozana]

Those metadata fields that use tagit are not validated correctly.
S. also https://forum.pkp.sfu.ca/t/disciplines-required-not-passing-although-field-is-completed-ojs-3-1/34747/3

[bozana]

PRs:
pkp-lib master: #3158
ojs master: pkp/ojs#1747 (only submodule update)

pkp-lib ojs-stable-3_1_0: #3159
ojs ojs-stable-3_1_0: pkp/ojs#1748 (only submodule update)

[bozana]

@NateWr, could you take a look at the PR above?

[NateWr]

I left one comment in the code, just trying to get my head around it.

I also ran into a couple of related issues. I've added disciplines and set it to required. I've added some items to the discipline tag it and saved it. Now if I go back and remove them and save it, the form saves successfully, but the tags are still t here.

Also, if I go to a submission without any disciplines and I submit the form, I get an unhelpful error message:

Is there any way we can improve that?

[bozana]

Yes, that is an unhelpful error message -- it was like this before -- I will try to add the appropriate locale keys...

And concerning the second one:

Now if I go back and remove them and save it, the form saves successfully, but the tags are still t here.

Do you see the same error message but in the very background, on the page behind the modal, thus almost invisible? -- I always have this strange issue... and do not know why... I.e. I think the error message is there, just very hard visible, and thus the form as such not saved, then reloaded with the current submission fields (as always)...

[NateWr]

Do you see the same error message but in the very background, on the page behind the modal, thus almost invisible?

Oh I do see it. It looks like it is getting embedded into the body of the page instead of flying up the side. Looking at the response to the ajax request, it looks like it's returning an inPlace notification. Maybe there's some setting of the notification that's off?

[bozana]

@NateWr, I've added the appropriate form validation locale keys.
I still do not understand why the errors are displayed on the page :-P -- will take a further look tomorrow...
Thanks a lot!

[bozana]

@NateWr, now that the submission metadata form validation messages are correctly displayed, I think this issue/PR is finished. Could you take a final look? THANKS!!!

[NateWr]

New PRs which I'll merge when the tests pass:
#3241
pkp/ojs#1781

[NateWr]

All merged.