Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct missing escaping in searchResults.tpl #3805

Closed
asmecher opened this issue Jun 18, 2018 · 1 comment
Closed

Correct missing escaping in searchResults.tpl #3805

asmecher opened this issue Jun 18, 2018 · 1 comment
Assignees
Labels
Bug

Comments

@asmecher
Copy link
Member

@asmecher asmecher commented Jun 18, 2018

The searchQuery template variable presents user-supplied information without proper escaping. This permits a reflected (non-persistent) XSS attack.

Instructions to patch are here: #3805 (comment)

Affects OMP between 1.2.0 and 3.1.1-2 (inclusive).

https://nvd.nist.gov/vuln/detail/CVE-2018-12588
Thanks to Metamorfosec for discovery & reporting.

@asmecher asmecher added this to the OJS/OMP 3.1.1-2 milestone Jun 18, 2018
@asmecher asmecher self-assigned this Jun 18, 2018
asmecher added a commit to pkp/omp that referenced this issue Jun 18, 2018
asmecher added a commit to pkp/omp that referenced this issue Jun 18, 2018
asmecher added a commit to pkp/omp that referenced this issue Jun 18, 2018
asmecher added a commit to pkp/omp that referenced this issue Jun 18, 2018
@asmecher
Copy link
Member Author

@asmecher asmecher commented Jun 18, 2018

This can be corrected for OMP between 1.2.0 and 3.1.1-1 (inclusive) by applying this patch: https://github.com/pkp/omp/commit/ebf3a701708112f4973d02f26a0b1d746dcd4970.diff

OMP 1.2.0 to 3.1.1-2 additionally need the following patch:
pkp/omp@15ab902

For example, on most Linux systems this should work. Run it inside the OJS installation directory.

wget -q -O - https://github.com/pkp/omp/commit/ebf3a701708112f4973d02f26a0b1d746dcd4970.diff | patch -p1
wget -q -O - https://github.com/pkp/omp/commit/15ab9027bfdfbf742616a62a2bbafec3d217dbeb.diff | patch -p1

You should see the following output for each of the two commands:

patching file templates/frontend/pages/searchResults.tpl

The issue is corrected in OMP 3.1.1-3 and newer.

If you're using checkouts from git, all stable branches (e.g. omp-stable-3_1_1) have been patched.

@asmecher asmecher closed this Jun 18, 2018
@asmecher asmecher changed the title Correct missing escaping in "catalog.noTitlesSearch" Correct missing escaping in searchResults.tpl Jun 22, 2018
asmecher added a commit to pkp/omp that referenced this issue Jun 22, 2018
…talog.foundTitleSearch
asmecher added a commit to pkp/omp that referenced this issue Jun 22, 2018
…talog.foundTitleSearch
asmecher added a commit to pkp/omp that referenced this issue Jun 22, 2018
…talog.foundTitleSearch
asmecher added a commit to pkp/omp that referenced this issue Jun 22, 2018
…talog.foundTitleSearch
@asmecher asmecher added the Bug label Jun 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.