Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement internal Editorial Report UI and algorithms #4844

Open
jmacgreg opened this issue Jun 25, 2019 · 3 comments

Comments

@jmacgreg
Copy link
Member

commented Jun 25, 2019

From PKP 2019 sprint; see this specification for more information. Discussion should happen in this issue.

@jmacgreg jmacgreg self-assigned this Jun 25, 2019

@jmacgreg jmacgreg added this to To Do in Statistics Framework via automation Jun 25, 2019

jonasraoni added a commit to jonasraoni/ui-library that referenced this issue Aug 8, 2019

jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Aug 8, 2019

jonasraoni added a commit to jonasraoni/ojs that referenced this issue Aug 8, 2019

@jmacgreg

This comment has been minimized.

Copy link
Member Author

commented Aug 20, 2019

Hi Jonas, this is looking great so far! Some comments/fix suggestions:

  • Change the top "Editorial Activity" title to "Current Workflow Overview".
  • Remove the date picker option from the top chart, as I don't think it has any effect there.
  • For OJS, remove the "Internal Review" option, and rename "External Review" to simply "Review". For OMP (if we port this function over) the phrasing can stay the same, as OMP has internal and external review, but OJS doesn't.
  • limit the behaviour of the date picker and filter options to the chart or table that they "belong" to; or somehow otherwise streamline how these are applied. This may be a bit more difficult, I'm not really sure, and it could probably use a review by @NateWr. Right now there are multiple different locations to choose date spans and apply the filters - basically, the tools are available for each chart and table on the page, but apply across the whole page (where applicable) and that looks confusing. So perhaps I'd suggest one of the following:
    • have the controls in one location only, at the top of the page, to be applied universally; OR
    • have the controls at the top of each chart/table, but only the controls that apply there, and have them only apply to that one chart/table.

@jmacgreg jmacgreg removed their assignment Aug 20, 2019

@NateWr

This comment has been minimized.

Copy link
Contributor

commented Aug 20, 2019

@jonasraoni do you mind opening a PR for OJS/pkp-lib for your changes? That will make it easier for me to do a review. I'll try to take a closer look this week.

@jonasraoni

This comment has been minimized.

Copy link
Contributor

commented Aug 20, 2019

Done @NateWr! As @jmacgreg asked to develop this feature over /stable-3_1_2, I've opened the PRs against it... Let me know if I should change the target to /master.

I'll add some comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.