Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to 3.3.x can be interrupted due to non-conforming *_settings tables #9487

Closed
jonasraoni opened this issue Nov 4, 2023 · 0 comments · Fixed by pkp/ojs#4096, #9539, #9540, pkp/omp#1486 or pkp/ops#598
Closed

Upgrade to 3.3.x can be interrupted due to non-conforming *_settings tables #9487

jonasraoni opened this issue Nov 4, 2023 · 0 comments · Fixed by pkp/ojs#4096, #9539, #9540, pkp/omp#1486 or pkp/ops#598
Assignees
@jonasraoni
Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users.
Milestone
3.3.0-17

Comments

@jonasraoni
Copy link
Contributor

jonasraoni commented Nov 4, 2023 •
edited
Loading

Describe the bug
Due to the code at:
https://github.com/pkp/ojs/blob/a9f7c9abd67c94cdb0d3d0c7b0100d5eb74a7c0a/classes/migration/upgrade/OJSv3_3_0UpgradeMigration.inc.php#L101-L113

A non-conforming settings table (e.g. missing any of the setting_type/setting_name/'setting_value` columns), possibly created by a plugin/user, might fail the upgrade when it's near to its completion.

The offending entity in my use-case was a rt_settings table, inherited from an OJS 2.x installation.

What application are you using?
OJS 3.3
@jonasraoni jonasraoni added the Bug:1:Low A bug that does not have a severe consequence or affects a small number of users. label Nov 4, 2023
@jonasraoni jonasraoni self-assigned this Nov 4, 2023
jonasraoni added a commit to jonasraoni/ojs that referenced this issue Nov 4, 2023
@jonasraoni
pkp/pkp-lib#9487 Skipped non-conforming setting tables from failing t…
0d22700 
…he migration
@jonasraoni jonasraoni linked a pull request Nov 4, 2023 that will close this issue
pkp/pkp-lib#9487 Skipped non-conforming setting tables from failing the migration pkp/ojs#4096
Merged
@asmecher asmecher added this to the 3.3.0-17 milestone Nov 20, 2023
@jonasraoni jonasraoni modified the milestones: 3.3.0-17, 3.4.0-5 Nov 27, 2023
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Nov 27, 2023
@jonasraoni
pkp#9487 Skipped non-conforming setting tables from failing the migra…
7629c11 
…tion
jonasraoni added a commit to jonasraoni/ojs that referenced this issue Nov 27, 2023
@jonasraoni
pkp/pkp-lib#9487 Submodule update ##jonasraoni/bugfix/stable-3_4_0/94…
a9a07ba 
…87-fix-migration-exception##
This was linked to pull requests Nov 27, 2023
pkp/pkp-lib#9487 Skipped non-conforming setting tables from failing t… #9539
Merged
pkp/pkp-lib#9487 TESTS ONLY pkp/ojs#4112
Closed
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Nov 27, 2023
@jonasraoni
pkp#9487 Skipped non-conforming setting tables from failing the migra…
2ddb204 
…tion
jonasraoni added a commit to jonasraoni/ojs that referenced this issue Nov 27, 2023
@jonasraoni
pkp/pkp-lib#9487 Submodule update ##jonasraoni/bugfix/stable-3_4_0/94…
82096f3 
…87-fix-migration-exception##
This was linked to pull requests Nov 27, 2023
pkp/pkp-lib#9487 TESTS ONLY pkp/ojs#4113
Closed
pkp/pkp-lib#9487 Skipped non-conforming setting tables from failing t… #9540
Merged
jonasraoni added a commit to jonasraoni/ops that referenced this issue Nov 27, 2023
@jonasraoni
pkp/pkp-lib#9487 Skipped non-conforming setting tables from failing t…
0f44abb 
…he migration
jonasraoni added a commit to jonasraoni/omp that referenced this issue Nov 27, 2023
@jonasraoni
pkp/pkp-lib#9487 Skipped non-conforming setting tables from failing t…
ca6d39d 
…he migration
This was linked to pull requests Nov 27, 2023
pkp/pkp-lib#9487 Skipped non-conforming setting tables from failing t… pkp/omp#1486
Merged
pkp/pkp-lib#9487 Skipped non-conforming setting tables from failing t… pkp/ops#598
Merged
jonasraoni added a commit to jonasraoni/ojs that referenced this issue Jan 11, 2024
@jonasraoni
pkp/pkp-lib#9487 Skipped non-conforming setting tables from failing t…
09ba442 
…he migration
jonasraoni added a commit to jonasraoni/ojs that referenced this issue Jan 11, 2024
@jonasraoni
pkp/pkp-lib#9487 Included common fields for extra reliability
3645c40
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Jan 11, 2024
@jonasraoni
pkp#9487 Skipped non-conforming setting tables from failing the migra…
c6cbf35 
…tion
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Jan 11, 2024
@jonasraoni
pkp#9487 Included common fields for extra reliability
fd28022
jonasraoni added a commit to jonasraoni/ojs that referenced this issue Jan 11, 2024
@jonasraoni
pkp/pkp-lib#9487 Submodule update ##jonasraoni/bugfix/stable-3_4_0/94…
de60a71 
…87-fix-migration-exception##
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Jan 11, 2024
@jonasraoni
pkp#9487 Skipped non-conforming setting tables from failing the migra…
780ddc7 
…tion
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Jan 11, 2024
@jonasraoni
pkp#9487 Included common fields for extra reliability
55cdcd9
jonasraoni added a commit to jonasraoni/ojs that referenced this issue Jan 11, 2024
@jonasraoni
pkp/pkp-lib#9487 Submodule update ##jonasraoni/bugfix/stable-3_4_0/94…
5db8abe 
…87-fix-migration-exception##
jonasraoni added a commit to jonasraoni/ops that referenced this issue Jan 11, 2024
@jonasraoni
pkp/pkp-lib#9487 Skipped non-conforming setting tables from failing t…
42d4db1 
…he migration
jonasraoni added a commit to jonasraoni/ops that referenced this issue Jan 11, 2024
@jonasraoni
pkp/pkp-lib#9487 Included common fields for extra reliability
8ee19aa
jonasraoni added a commit to jonasraoni/omp that referenced this issue Jan 11, 2024
@jonasraoni
pkp/pkp-lib#9487 Skipped non-conforming setting tables from failing t…
d96cf22 
…he migration
jonasraoni added a commit to jonasraoni/omp that referenced this issue Jan 11, 2024
@jonasraoni
pkp/pkp-lib#9487 Included common fields for extra reliability
91ae830
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Jan 11, 2024
@jonasraoni
pkp#9487 Included common fields for extra reliability
c64eaeb
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Jan 11, 2024
@jonasraoni
pkp#9487 Included common fields for extra reliability
24c0329
jonasraoni added a commit to jonasraoni/ojs that referenced this issue Jan 11, 2024
@jonasraoni
pkp/pkp-lib#9487 Submodule update ##jonasraoni/bugfix/stable-3_4_0/94…
c3de621 
…87-fix-migration-exception##
jonasraoni added a commit to pkp/ojs that referenced this issue Jan 11, 2024
@jonasraoni
Merge pull request #4096 from jonasraoni/bugfix/stable-3_3_0/9487-fix…
2daac84 
…-migration-exception

pkp/pkp-lib#9487 Skipped non-conforming setting tables from failing the migration
jonasraoni added a commit that referenced this issue Jan 11, 2024
@jonasraoni
Merge pull request #9539 from jonasraoni/bugfix/stable-3_4_0/9487-fix…
a52cde3 
…-migration-exception

#9487 Skipped non-conforming setting tables from failing t…
jonasraoni added a commit that referenced this issue Jan 11, 2024
@jonasraoni
Merge pull request #9540 from jonasraoni/bugfix/main/9487-fix-migrati…
6453a59 
…on-exception

#9487 Skipped non-conforming setting tables from failing t…
jonasraoni added a commit to pkp/omp that referenced this issue Jan 11, 2024
@jonasraoni
Merge pull request #1486 from jonasraoni/bugfix/stable-3_3_0/9535-ski…
91390d4 
…p-invalid-submission-files

pkp/pkp-lib#9487 Skipped non-conforming setting tables from failing t…
jonasraoni added a commit to pkp/ops that referenced this issue Jan 11, 2024
@jonasraoni
Merge pull request #598 from jonasraoni/bugfix/stable-3_3_0/9535-skip…
23ba519 
…-invalid-submission-files

pkp/pkp-lib#9487 Skipped non-conforming setting tables from failing t…
ipula pushed a commit to ipula/pkp-lib that referenced this issue Jan 11, 2024
@jonasraoni @ipula
pkp#9487 Skipped non-conforming setting tables from failing the migra…
6990103 
…tion
ipula pushed a commit to ipula/pkp-lib that referenced this issue Jan 11, 2024
@jonasraoni @ipula
pkp#9487 Included common fields for extra reliability
d9a1a04
@jonasraoni jonasraoni mentioned this issue Jul 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonasraoni jonasraoni

Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users.
Projects
None yet
Milestone
3.3.0-17
2 participants
@asmecher @jonasraoni