Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
pkp/pkp-lib#3617 Support for MS SQL #3603
@nibou230, excellent work, thanks again. I've made some general comments, and as per the OJS pull request, the less we have to specifically consider SQL Server as an exception in the code, the better -- I don't see many cases where we can't code behavior that suits all 3 DBMSs, rather than having special cases with different SQL.
I'd also suggest removing the ADODB library entirely from the repository, and adding it instead as a Composer dependency (see
@nibou230, I've picked the trivial fixes (reference warnings etc.) from this and merged them into