pkp/pkp-lib#7213 Fix Announcement Email #7547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks for this @rahmanramsi! The code looks good. Before we can merge it, we need to run the integration tests against the new code. This requires a special commit and pull request to OJS. You can read how to do this in our documentation here: https://docs.pkp.sfu.ca/dev/testing/en/continuous-integration#tests-for-pull-requests Once you have the pull request for OJS with the submodule commit, can you add a comment to #7213 with a link to both pull requests? Once the tests are passing I'll do a final review and merge. 👍 |
|
Sure, gonna do that. thanks for reviewing it @NateWr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug when on Add Announcement form, check box for sending an email to all registered users is checked, no email is sent. #7213