Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish: create and push git tags without versioning #69

Closed
MarcoIeni opened this issue Apr 11, 2022 · 6 comments
Closed

publish: create and push git tags without versioning #69

MarcoIeni opened this issue Apr 11, 2022 · 6 comments

Comments

@MarcoIeni
Copy link

Can the command cargo workspaces publish create and push a tag after/before the crate is published?

@pksunkara
Copy link
Owner

It does before publishing.

@MarcoIeni
Copy link
Author

MarcoIeni commented Apr 11, 2022

Oh, I see. It does it normally, but not when the --from-git flag is set.
Would it be possible to create and push tags even when this flag is set?

@pksunkara
Copy link
Owner

That flag is used when you are supposed to already have tags. Maybe you want a different things? What are you trying to do?

@MarcoIeni
Copy link
Author

My use case is that Cargo.toml contains the new version and is committed in git.
That's why I use the --from-git flag. However, I wish I could create the tag automatically with cargo workspaces when publishing.
Cargo.toml is updated with https://github.com/MarcoIeni/release-plz

@pksunkara
Copy link
Owner

From the wisdom of all the last few years of working with release tools in all kinds of package managers, the tool which updates Cargo.toml and commits needs to be the same tool which creates the tags too. In this case, release-plz is the one that needs to create tags, if you don't plan to use cargo workspaces version bumping functionality.

@pksunkara pksunkara changed the title publish: create and push git tags publish: create and push git tags without versioning Apr 12, 2022
@MarcoIeni
Copy link
Author

Ok, thank you for your time and the quick replies :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants