Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Hostname is hardcoded #82

Closed
floatdrop opened this Issue Dec 24, 2013 · 6 comments

Comments

Projects
None yet
3 participants

I think this is bad. We should have way specify hostname from options.

Owner

pksunkara commented Dec 24, 2013

I dont understand why it is bad since this is an api library for github.

Can you explain your thinking?

Contributor

joshrp commented Dec 24, 2013

Its not ideal having hard coded hostnames.

I'd like to have more robust testing one day using a fake github api server
that serves only fixtures which this would need fixing for.

But then again that can be changed when required rather than just changing
it for no reason.
On 24 Dec 2013 18:15, "Pavan Kumar Sunkara" notifications@github.com
wrote:

I dont understand why it is bad since this is an api library for github.


Reply to this email directly or view it on GitHubhttps://github.com/pksunkara/octonode/issues/82#issuecomment-31180995
.

Owner

pksunkara commented Dec 24, 2013

Will fix it sometime later. :)

Well, I forced to work also with enterprise version of github - so the hostname is different for me, @pksunkara 😄

Contributor

joshrp commented Dec 24, 2013

Good point, this should be a config parameter then, no doubt.
On 24 Dec 2013 18:34, "Vsevolod Strukchinsky" notifications@github.com
wrote:

Well, I forced to work also with enterprise version of github - so the
hostname is different for me, @pksunkara https://github.com/pksunkara [image:
😄]


Reply to this email directly or view it on GitHubhttps://github.com/pksunkara/octonode/issues/82#issuecomment-31181501
.

@pksunkara pksunkara closed this in 94e05ef Dec 24, 2013

That was fast! Thank you! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment