Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Pass response and headers into callback when search request is not finished with http status 200 #92

Closed
gamtiq opened this Issue Feb 1, 2014 · 0 comments

Comments

Projects
None yet
1 participant

gamtiq commented Feb 1, 2014

Hello,

First of all, I would like to thank you for the good library.

Is there a serious reason not to pass response body and headers when search request is finished with http status that differs from 200?
The current implementation prevents analyzing of response in some situations. For example, GitHub returns 403 Forbidden when API rate limit is exceeded and (imho) it is normal response that can and should be processed in application code.
Moreover the current search implementation violates unification of callbacks.
Is it possible to add response body and headers as parameters to callbacks that are called when response http status is not 200?

Best regards,
Denis

@pksunkara pksunkara closed this in 70bb1f0 Feb 1, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment