Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Membership check for an individual user is returning the incorrect results #75

Merged
merged 1 commit into from Dec 5, 2013

Conversation

Projects
None yet
2 participants
Contributor

suprememoocow commented Dec 5, 2013

In a previous pull request I added a check for 302 for the membership check. This is in fact incorrect. I would very much like to write a test case for this too, but the case I need to implement needs to act as authenticated user and I am obviously not keen on publishing any of my own access tokens.

I guess we can keep the access token in an environment variable or somewhere on your file system outside of the source control. How would you like this done?

Owner

pksunkara commented Dec 5, 2013

My main question for this is how can we test if the tests are written by keeping in mind someone's access token?

The github api v3 is always backwards compatible. So, I just test once using a sample script and leave it that. Atleast that's how I tested during the intial stages.

pksunkara added a commit that referenced this pull request Dec 5, 2013

Merge pull request #75 from troupe/membership2
Membership check for an individual user is returning the incorrect results

@pksunkara pksunkara merged commit 05db559 into pksunkara:master Dec 5, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment