Added ability to specify a proxy server for requests. #84

Merged
merged 1 commit into from Dec 30, 2013

Conversation

Projects
None yet
2 participants
Contributor

joshrp commented Dec 30, 2013

It will now respect environment proxy settings in HTTP_PROXY

This meant refactoring how request options are put together and adds a new dependency on utils-extend, but it now means all of the options passed to request are customisable

Josh Priestley
Added ability to specify a proxy server for requests.
This meant refactoring how `request` options are put together and adds a new dependency on `utils-extend`
Owner

pksunkara commented Dec 30, 2013

Have you tested this?

Contributor

joshrp commented Dec 30, 2013

Yes, on my machine using proxies and no proxies, but I don't have a very full implementation of the API to test every case against. Would be good if someone could give it a whirl first

Owner

pksunkara commented Dec 30, 2013

Could you test it with the following script? (The script sees your github hooks and asks you if you want to delete any)

https://gist.github.com/pksunkara/7981618

I just want to make sure the addition of requestOptions doesn't break any.

Contributor

joshrp commented Dec 30, 2013

It ran fine and listed all zero hooks which I have access too. I can't test any more than that using the script.

pksunkara added a commit that referenced this pull request Dec 30, 2013

Merge pull request #84 from joshrp/add_proxy
Added ability to specify a proxy server for requests.

@pksunkara pksunkara merged commit f609039 into pksunkara:master Dec 30, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment