Pavan Kumar Sunkara pksunkara

Organizations

@flatiron @apiaryio @alpaca-api @asm-products @sunapps @osapps @termapps
pksunkara commented on pull request refractproject/refract-spec#33
@pksunkara

This is okay with me to merge.

pksunkara deleted branch smizell/fix-empty-responses at apiaryio/fury.js
@pksunkara
pksunkara merged pull request apiaryio/fury.js#35
@pksunkara
Fix parsing of empty responses in Swagger
1 commit with 125 additions and 8 deletions
pksunkara commented on pull request apiaryio/fury.js#35
@pksunkara

No problem. Just wanted to confirm with you before merging.

pksunkara commented on pull request apiaryio/fury.js#35
@pksunkara

When there is either no response or only the default response in a swagger transition, we had to create a httpTransaction with empty response and r…

@pksunkara
  • @pksunkara bc5da3c
    Corrected integration tests
@pksunkara
@pksunkara

Hey, The API Blueprint does not support self-references in MSON. At least for now.

@pksunkara
pksunkara commented on pull request refractproject/rfcs#1
@pksunkara

I have reviewed and commented on with my opinions.

pksunkara commented on pull request refractproject/rfcs#1
@pksunkara

:+1: I agree. Calling them attributes is quite confusing with refract's attributes. I generally say body params when I am explaining it to other users.

pksunkara commented on pull request refractproject/rfcs#1
@pksunkara

In my mind, I consider the MSON under the attributes section of a resource to be it's schema.

pksunkara commented on pull request refractproject/rfcs#1
@pksunkara

I think calling them classes will be quite confusing.

@pksunkara
Incorrect parsing of attributes with underscores
@pksunkara

Hey, If you read the MSON spec, you can see that _ is a reserved character. Please use backticks to escape the whole word. Here is an example: + `g…

pksunkara deleted branch klokane/refract-handle-complex-array-members at apiaryio/drafter
pksunkara deleted branch klokane/refract-fix-array at apiaryio/drafter
@pksunkara
pksunkara merged pull request apiaryio/drafter#58
@pksunkara
Refract - fix array expansion
1 commit with 128 additions and 59 deletions
pksunkara deleted branch kylef/action-uri-template at apiaryio/Paw-APIBlueprintImporter
@pksunkara
@pksunkara
Support URI Templates attached to an action
1 commit with 34 additions and 4 deletions
pksunkara commented on pull request refractproject/refract-spec#33
@pksunkara

I would appreciate if you do it. Sometimes it can be quite confusing.

pksunkara commented on pull request refractproject/refract-spec#33
@pksunkara

Only one comment otherwise lgtm. :+1:

pksunkara commented on pull request refractproject/refract-spec#33
@pksunkara

Can we have some example content here? Thanks.

@pksunkara

Hey @Saviio, Can you link me the whole API Blueprint file? I would like test if it's an error in the parser or not. Thanks.

pksunkara commented on pull request apiaryio/fury.js#34
@pksunkara

Yes. I forgot to link it here.

@pksunkara
Same response with different body objects depending on the presence of a query parameter
@pksunkara

The feature you are requesting in the first question can be tracked at #58. The answer to you second question is Attributes section. Please keep in…