Skip to content
This repository

Sep 21, 2012

  1. Ævar Arnfjörð Bjarmason

    t/Plack-Request/cookie.t: add documentation to some of the trickier t…

    Change the t/Plack-Request/cookie.t tests to use three-arg is() for
    the undef tests and the multi-cookie test.
    avar authored

Aug 13, 2012

  1. Scott S. McCoy

    Path escaping regex supports RFC 3986 definition.

     * Updated the class of characters-to-not-escape passed to URI::Escape to
       support the proper definition as stipulated by RFC 3986 for URL Paths,
        safe           = "$" | "-" | "_" | "." | "+"
        extra          = "!" | "*" | "'" | "(" | ")" | ","
        unreserved     = alpha | digit | safe | extra
        escape         = "%" hex hex
        uchar          = unreserved | escape
        hpath          = hsegment *[ "/" hsegment ]
        hsegment       = *[ uchar | ";" | ":" | "@" | "&" | "=" ]
     * Added unit test which verifies behavior by attempting to use path
    ssmccoy authored

Jun 27, 2012

  1. Yann Kerhervé

    Fix parsing of QUERY_STRING for valueless keys.

    For a given 'QUERY_STRING: foo&bar=baz' the 'foo' parameter is not
    accessible in Plack::Request::query_parameters(). There are a number of
    applications using this pattern as a short way of passing information to
    the handling code. This patch changes Plack::Request behaviour so that
    foo makes its way in the underlaying Hash::MultiValue object as a key
    with the empty string value. Application developers can now test the
    existence of that key.
    yannk authored

Mar 10, 2011

  1. Tatsuhiko Miyagawa

    Fixed the way overriding ENV for Plack::Loader auto detection for Win…

    …32. Fixes gh-179
    miyagawa authored

Mar 04, 2011

  1. Tatsuhiko Miyagawa

    Clear %ENV for tests that use Plack::Test with the servers so it will…

    … run with the default server
    miyagawa authored

Dec 15, 2010

  1. Daisuke Murase

    add unit test for 7defd23

    typester authored

Sep 09, 2010

  1. Tatsuhiko Miyagawa

    Save HTTP::Body object in the other $env key rather than in $req

    This ensures the cleanup happens in the $env cleanup rather than $req
    destroy which might be too early if we instnatiate Plack::Request
    multiple times, once in middleware and the other in the app.
    miyagawa authored
  2. Johannes Plunien

    Clean up temporary files created by uploads (and HTTP::Body).

    plu authored miyagawa committed

Jul 03, 2010

  1. Tatsuhiko Miyagawa

    fix URI construction when PATH_INFO contains URI reserved characters …

    …such as ? or #. Fixes gh-118
    miyagawa authored

Apr 17, 2010

  1. Tatsuhiko Miyagawa

    Replace kyoto.jpg with medium size baybridge.jpg to trim down the tar…

    …ball size
    miyagawa authored

Mar 12, 2010

  1. Tatsuhiko Miyagawa

    diag its content when it fails

    miyagawa authored

Jan 31, 2010

  1. Tatsuhiko Miyagawa

    unuse Test::Base

    miyagawa authored
  2. Tatsuhiko Miyagawa

    rm unused deps

    miyagawa authored

Jan 30, 2010

  1. Tatsuhiko Miyagawa

    give Content-Type in content upload test

    miyagawa authored

Jan 29, 2010

  1. Tatsuhiko Miyagawa

    Added a test for $req->base

    miyagawa authored
  2. Tatsuhiko Miyagawa

    Consolidated ->base and ->uri and cache those results in the env, but

    uses ->clone to create a new URI object.
    miyagawa authored

Jan 28, 2010

  1. Tatsuhiko Miyagawa

    INCOMPATIBLE: deleted slurp, link_to, copy from Plack::Request::Upload.

    Added ->content_type and ->path shortcut to get Content-Type and
    temporary file path.
    miyagawa authored
  2. Tatsuhiko Miyagawa

    INCOMPATIBLE: Do not use CGI::Simple::Cookie to generate cookies.

    This means:
      * Now support httponly in the cookie attributes.
      * Does not auto-convert strings like '+1d' for expires. Use epoch timestamp for this.
      * Does not join the list with '&' if value is an array ref or an hash ref.
        Always pass strings.
    miyagawa authored
  3. Tatsuhiko Miyagawa

    more cookie testing for escapes etc.

    miyagawa authored
  4. Tatsuhiko Miyagawa

    Implemented Plack::TempBuffer to automatically switch PerlIO and Temp

    file based buffering for request uploads. Added a test to verify large
    file uploads via Mock and Server.
    miyagawa authored

Jan 27, 2010

  1. Tatsuhiko Miyagawa

    Let $req->content not barf when there's no Content-Type (i.e. GET/HEA…

    …D requests)
    miyagawa authored
  2. Tatsuhiko Miyagawa

    Deprecated (undocumented anyway) raw_uri infavor of base and request_…

    miyagawa authored
  3. Tatsuhiko Miyagawa

    fix test plan

    miyagawa authored
  4. Tatsuhiko Miyagawa

    Deprecated $req->cookie since you can just use ->cookies to get a

    hashref to get the list of cookie names.
    _deprecated now suggests an alternative method name.
    $req->path now returns $req->path_info since that's usually what qmost
    frameworks want. Use $req->uri->path (which is SCRIPT_NAME +
    PATH_INFO) if that is NOT the case.
    miyagawa authored
  5. Tatsuhiko Miyagawa

    INCOMPATIBLE: no longer use CGI::Simple::Cookie to parse cookies.

    $req->cookie($name) returns *a string* instead of an object to
    represent cookie values. You no longer have to check if cookie()
    returns an object and then call ->value method on it.
    No longer auto deflate hash refs and array refs by splitting them with
    '&': that's a de-facto standard way of encoding cookies, originated
    from and used in CGI::Simple::Cookie, cgi.rb and everywhere
    else, but it lets you write a code like:
      $res->cookies->{foo} = { bar => 1 };
      %v = $req->cookie('foo') ? $req->cookie('foo')->values : ();
    and it doesn't really allow you to serailize nested hash/arrays
    anyway, hence fragile and just ugly.
    (Plack::Response still does this '&' concatenation; fixes coming soon)
    miyagawa authored
  6. Tatsuhiko Miyagawa

    Some code and doc cleanups.

    Made cookies() method read only and only parse once and save the
    result in $env.
    miyagawa authored

Jan 21, 2010

  1. Tatsuhiko Miyagawa

    rm unused chunk of tests

    miyagawa authored
  2. Tatsuhiko Miyagawa

    CHANGE: all param() and params() are now read-only.

    parameters() (and body/query_parameters() and aliases) now returns
    Hash::MultiValue object instead of scalar-or-array-ref. YAY!
    miyagawa authored
  3. Tatsuhiko Miyagawa

    Make psgi.input rewindable by saving the read body into a temp file

    when parsing. Saves POST parameters and Upload objects using
    Hash::MultiValue, so params() would always return the last parameter
    found, while ->get_all would allow you to get the all values in a
    Still uses HTTP::Body but removed a BodyParser object. Made a
    temporary hack to not spin loop more than 2000 times when parsing, to
    avoid DoS with wrong Content-Length values.
    miyagawa authored
  4. Tatsuhiko Miyagawa

    REVERTED $req->body returns psgi.input IO handle and ->content just

    slurps from there.
    miyagawa authored
  5. Tatsuhiko Miyagawa

    DEPRECATE $req->raw_body.

    Make $req->body and $req->content just the alias for what was called
    raw_body (returning the raw input body)
    miyagawa authored
  6. Tatsuhiko Miyagawa

    DEPRECATED: $req->hostname is deprecated, and doesn't do

    IP-to-hostname lookups anymore.
    Added $req->remote_host which just returns REMOTE_HOST.
    miyagawa authored

Jan 20, 2010

  1. Tatsuhiko Miyagawa

    Copied Plack::Request, Response and its tests from Plack-Request dist.

    Tests are adjusted to work with Plack::Test or standalone. All tests
    are unmodified YET, to make all the backward incompatilbe changes can
    be visible from now on, on this 'plack-request' branch.
    miyagawa authored

Oct 13, 2009

  1. Tatsuhiko Miyagawa

    remove Request and Catalyst stuff

    miyagawa authored
  2. Tatsuhiko Miyagawa

    Added ro methods -raw_uri and ->base

    miyagawa authored
Something went wrong with that request. Please try again.