Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Restarter doesn't kill the right process #327

Open
jspin opened this Issue · 1 comment

2 participants

@jspin

Hi, I just updated to v1.0003 and am still experiencing an issue similar to #223.

here's how I'm launching the app and what it reports afterward:

/usr/local/bin/plackup -s FCGI --port 8088 --host 127.0.0.1 -R lib -D bin/plack-responder.psgi &
FastCGI daemon started (pid 21614)

ps -ef | grep fcgi
ec2-user 21614 1 0 14:14 ? 00:00:00 perl-fcgi-pm
ec2-user 21615 21614 0 14:14 ? 00:00:00 perl-fcgi

( then when I update a module)

-- /web/live/lib/XXX/App/Main/List.pm updated.
Killing the existing server (pid:20722)
Successfully killed! Restarting the new server process.
bind/listen: Address already in use
-- /web/live/lib/XXX/App/Main/List.pm updated.
Killing the existing server (pid:21611)
Successfully killed! Restarting the new server process.
-- /web/live/lib/XXX/App/Main/List.pm updated.
-- /web/live/lib/XXX/App/Main/List.pm updated.
Killing the existing server (pid:20728)
Successfully killed! Restarting the new server process.
Killing the existing server (pid:20725)
Successfully killed! Restarting the new server process.
bind/listen: Address already in use
bind/listen: Address already in use
bind/listen: Address already in use

(which process id's are running now?)

ps -ef | grep fcgi
ec2-user 21614 1 0 14:14 ? 00:00:00 perl-fcgi-pm
ec2-user 21615 21614 0 14:14 ? 00:00:00 perl-fcgi

none of the pid's supplied in the "Killing the existing server" message are correct. as you can see, the original pids are still running.

another thing I noticed compared to v0.9985, although fairly minor, is that it tries 3x instead of 2 to kill/restart and the updated module is listed twice on the 2nd attempt.

unless I'm launching the app incorrectly, this appears to be a bug.

thanks for looking
-Joe

@miyagawa
Owner

Do you still see this issue? I think restarter isn't really compatible to forking managers like FCGI::ProcManager.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.