Stop load_psgi from searching .psgi files from @INC

[miyagawa]

If you have foo.psgi in any of your @INC paths, running plackup foo.psgi used to try to load the one in there first rather than the current directory, which is listed as the last entry of include paths with usual perl.

This would confuse users potentially. With this change load_psgi function in Plack::Util does a little more DWIMmery to make it into ./foo.psgi unless the given path begins with / (slash).

Arguably this might break some users, who uses this feature for their CPAN modules to install PSGI scripts into @INC expecting it to be picked up by plackup foo.psgi. That will stop working, although we never recommended it, and if they have a module (not a script) like MyApp::PSGI into include paths that will keep working.

[miyagawa]

@plack/core care to take a look?

[doy]

+1 from me, this does seem like unexpected behavior. The other option
here would be to explicitly put . at the front of @INC before
loading the file, which might preserve existing behavior a bit better,
if that's important. Not sure if that would still end up being too
clever/confusing though.

[bobtfish]

+1 here, and -1 for pushing . onto @inc - this just adds more magic..

[KnowZero]

This change breaks Catalyst on Windows :(

C:\Sites\Test\script>perl64 test_server.pl
Error while loading ./C:\Sites\Test\test.psgi: No such file or directory at (eval 1307) line 4, line 1000.

Using ActiveState Perl 5.16 64bit on Windows 2008R2 64bit and IIS 7.5 and Plack 1.0007 and Catalyst 5.90016.

Is it possible to change line 128 of lib/Plack/Util.pm to:

$file =~ m!^(?:/|[a-zA-Z]\:)! ? $file : "./$file";

[miyagawa]

What's the content of test_server.pl?

[KnowZero]

The default Catalyst generates:

BEGIN {

$ENV{CATALYST_SCRIPT_GEN} = 40;

}

use Catalyst::ScriptRunner;

Catalyst::ScriptRunner->run('Test', 'Server');

1;

[KnowZero]

The problem is unlike Linux, Windows has drive letters and "./C:" is an invalid path.