Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Split Plack::Test::* to another dist #382

Closed
tokuhirom opened this Issue Mar 2, 2013 · 10 comments

Comments

Projects
None yet
4 participants
Member

tokuhirom commented Mar 2, 2013

Plack::Test::* depend to LWP, it makes slower to install Plack with Carton.
I suggest to split Plack-Test to the dist, and Plack depend to it.

Owner

miyagawa commented Mar 2, 2013

+1 ideally. It's not realistically that simple, since Plack::Test depends on many parts of Plack, and many Plack core tests are written with Plack::Test. (circular deps)

Owner

miyagawa commented Mar 2, 2013

I don't know about the Carton bit, since carton in 1.0 will install all the dependencies anyway (including test deps). we may choose to skip test deps for the deps (not root/app test deps) though.

Contributor

nichtich commented Aug 20, 2013

I suppose this is solved with the introduction of Plack::LWPish, isn't it?

Owner

miyagawa commented Aug 20, 2013

The requirement of LWP has been removed, but there's still a wishlist item to split Plack to smaller chunk of distributions.

Contributor

xsawyerx commented Jun 6, 2014

I can't find a reason to install Plack without Plack::Test once the requirement of LWP has been removed. I mean, if you're using something that uses Plack, it will most likely have tests.

Since the original requirement has been handled (LWP dependency), wouldn't it be nice to close the issue until there's another reason to suggest splitting?

Owner

miyagawa commented Jun 6, 2014

"Most likely" doesn't mean always. Runtime-only dist would be useful to
have in deployment environment where you don't need tests.

The plan is to have a runtime dist and test/development dist which will be
dependent from the core Plack dist so the current dependency will continue
to work.

Contributor

xsawyerx commented Jun 6, 2014

I think the fact that Plack comes with the testing utilities is a benefit. Having a runtime-only dist is also a benefit.

My question is simpler: is there someone who needs this feature right now? If so, let's do it. Otherwise, let's close the issue until it comes up again with a use-case. No reason to just keep it open.

Owner

miyagawa commented Jun 6, 2014

I think the fact that Plack comes with the testing utilities is a benefit. Having a runtime-only dist is also a benefit.

Yes that's the goal. We currently have one option to have them in one dist with dozens of dependencies. We'll provide more options so that depending on Plack will continue to work while depending on lighter deps for runtime only will also be possible.

My question is simpler: is there someone who needs this feature right now?

There's been a couple of requests like this on a mailing list and irc, and there's been a separate repo to make it happen as well: https://github.com/plack/Plack-Runner

Contributor

xsawyerx commented Jun 6, 2014

Ah! Excellent.

I see that's stalled. I'll try to poke into that and see what the status is, and maybe we could actually do it and resolve it quickly?

@miyagawa miyagawa closed this Jun 6, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment