Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

PATCH: lighttpd "fix" broke mod_rewrite + IIS in Plack #309

Open
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

Don't send me a patch, open a pull request on github. Thanks

Sent from my iPhone

On Thursday, June 28, 2012 at 6:52 AM, Thomas Zehetbauer wrote:

hi,

could you please include the attached patch with the next plack release?

we already reported this problem about eight months ago:
http://grokbase.com/t/sc/catalyst/11aswtme3s/plack-hanlder-fcgi-bug

lighttpd should be fixed instead of breaking apache + IIS
https://github.com/miyagawa/Plack/pull/284
https://github.com/miyagawa/Plack/issues/299
https://github.com/miyagawa/Plack/pull/300

TIA
Tom

From what was discussed prior, it seems that line is incorrectly commented on and the fix should effect every web server. During some situations of apache and all usage of IIS it backfires and destroys the PATH_INFO. So from what I was told a patch should be done to each individual middleware instead. And recover the PATH_INFO via REQUEST_URI.

I wrote a patch for IIS middleware and waiting on a commit:

https://github.com/miyagawa/Plack/pull/303/files

If Apache is needed I guess a similar middleware adjustment needs to be made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment