New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix errordocument for streaming responses in subrequests #339

Merged
merged 1 commit into from Oct 15, 2012

Conversation

Projects
None yet
2 participants
@doy
Member

doy commented Oct 15, 2012

Assigning directly to $res->[2] is wrong here, because the app itself could be using streaming, in which case it expects to receive a writer object back, but servers determine whether to return a writer object based on if the third element exists.

miyagawa added a commit that referenced this pull request Oct 15, 2012

Merge pull request #339 from plack/streaming-errordocument
fix errordocument for streaming responses in subrequests

@miyagawa miyagawa merged commit 33a5552 into master Oct 15, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment