Fix PATH_INFO check #349

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@degtyarev-dm

PATH_INFO can content empty string.
rfc3875: PATH_INFO = "" | ( "/" path )

@doy

This comment has been minimized.

Show comment Hide comment
@doy

doy Nov 11, 2012

Member

This should use ne for string equality. Also, adding a test for the incorrect behavior would be helpful.

Member

doy commented Nov 11, 2012

This should use ne for string equality. Also, adding a test for the incorrect behavior would be helpful.

@miyagawa

This comment has been minimized.

Show comment Hide comment
@miyagawa

miyagawa Nov 11, 2012

Member

PATH_INFO here is PSGI's environment and it has nothing to do with RFC 3875 CGI environment variable.

That said: PSGI' PATH_INFO allows an empty string so I will fix it accordingly - as @doy said your fix is wrong.

Member

miyagawa commented Nov 11, 2012

PATH_INFO here is PSGI's environment and it has nothing to do with RFC 3875 CGI environment variable.

That said: PSGI' PATH_INFO allows an empty string so I will fix it accordingly - as @doy said your fix is wrong.

@miyagawa miyagawa closed this Nov 11, 2012

miyagawa added a commit that referenced this pull request Nov 11, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment