Added HTTP::Message::PSGI::res_to_psgi and HTTP::Response::to_psgi. #383

Open
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants
@tokuhirom
Member

tokuhirom commented Mar 3, 2013

This method is useful to pass a response of LWP as a PSGI response.

Concrete use case:

  • An PSGI application request to other API server with LWP, and just return HTTP response as a PSGI response array ref.
@miyagawa

This comment has been minimized.

Show comment Hide comment
@miyagawa

miyagawa Mar 8, 2013

Member

How about adding req_from_psgi too for consistency?

Member

miyagawa commented Mar 8, 2013

How about adding req_from_psgi too for consistency?

@tokuhirom

This comment has been minimized.

Show comment Hide comment
@tokuhirom

tokuhirom Mar 9, 2013

Member

Added req_from_psgi.

Member

tokuhirom commented Mar 9, 2013

Added req_from_psgi.

@miyagawa

This comment has been minimized.

Show comment Hide comment
@miyagawa

miyagawa Mar 9, 2013

Member

Okay, I'm not sure if it's a good idea to add a dependency to Plack::Request from HTTP::Message::PSGI, when we think about splitting the dists in the future (like separating out Plack::Test etc.).

Member

miyagawa commented Mar 9, 2013

Okay, I'm not sure if it's a good idea to add a dependency to Plack::Request from HTTP::Message::PSGI, when we think about splitting the dists in the future (like separating out Plack::Test etc.).

@tokuhirom

This comment has been minimized.

Show comment Hide comment
@tokuhirom

tokuhirom Mar 9, 2013

Member

Ah, it's hard to implement req_from_psgi without Plack::Request...
Let's merge 7ae7947 for now?

Member

tokuhirom commented Mar 9, 2013

Ah, it's hard to implement req_from_psgi without Plack::Request...
Let's merge 7ae7947 for now?

@tokuhirom

This comment has been minimized.

Show comment Hide comment
@tokuhirom

tokuhirom Mar 9, 2013

Member

(Because, it needs to buffering content body like Plack::Request, it's too large thing for HTTP::Message, i think.)

Member

tokuhirom commented Mar 9, 2013

(Because, it needs to buffering content body like Plack::Request, it's too large thing for HTTP::Message, i think.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment