Plack::App::File: Fix a security issue by not pruning trailing slashes #446
+31
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Before this Plack::App::File would prune trailing slashes via its split
invocation. I.e. it would think this:
Was the same as:
This can. turn into a nasty code exposure issue if you e.g. have an app
that basically does this:
This is also not how other webservers or Unix utilities work:
This resolves issue #405 that I filed around 9 months ago. I was
previously working around it in my own code by doing: